You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "kfaraz (via GitHub)" <gi...@apache.org> on 2024/05/01 02:38:54 UTC
Re: [PR] Correct log message (druid)
kfaraz commented on code in PR #16363:
URL: https://github.com/apache/druid/pull/16363#discussion_r1585813546
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -1805,7 +1805,7 @@ private void handleQueryResults(
Object resultObjectForStage = queryKernel.getResultObjectForStage(finalStageId);
if (!(resultObjectForStage instanceof List)) {
// This might occur if all workers are running on an older version. We are not able to write a manifest file in this case.
- log.warn("Was unable to create manifest file due to ");
+ log.warn("Was unable to create manifest file. Expected list of file names from worker, received [%s] instead.", resultObjectForStage);
Review Comment:
Nit: slight rephrase:
```suggestion
log.warn("Unable to create export manifest file. Received result[%s] from worker instead of a list of file names.", resultObjectForStage, finalStageId);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org