[GitHub] chetanmeh commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation

[GitBox <gi...@apache.org>]

chetanmeh commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation
URL: https://github.com/apache/incubator-openwhisk/pull/3517#discussion_r181287479
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/database/ArtifactStoreExceptions.scala
 ##########
 @@ -28,3 +28,9 @@ case class DocumentTypeMismatchException(message: String) extends ArtifactStoreE
 case class DocumentUnreadable(message: String) extends ArtifactStoreException(message)
 
 case class PutException(message: String) extends ArtifactStoreException(message)
+
+sealed abstract class ArtifactStoreRuntimeException(message: String) extends RuntimeException(message)
+
 
 Review comment:
   Made it `sealed` to follow the pattern used with `ArtifactStoreException` i.e. a base `RuntimeException` which can be used to indicate logical errors in code flow. So can be used for both views and document

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services