You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/29 14:24:29 UTC

[GitHub] [incubator-nuttx] fckruegel opened a new pull request #2161: Added Support for more TI Tiva Microcontrollers:

fckruegel opened a new pull request #2161:
URL: https://github.com/apache/incubator-nuttx/pull/2161


   * TM4C123GH6PZ (100 pin version of TM4C123GH6PM)
   * TM4C123GH6PGE (144 pin version of TM4C123GH6PM)
   * TM4C129ENCPDT (TM4C1294 with Crypto hardware added, TQFP package)
   * TM4C129ENCZAD (TM4C1294 with Crypto hardware added, BGA package)
   
   ## Summary
   
   ## Impact
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2161: Added Support for more TI Tiva Microcontrollers:

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2161:
URL: https://github.com/apache/incubator-nuttx/pull/2161#issuecomment-719143174


   There are other errors too:
   ```
   nuttx/arch/arm/src/tiva/hardware/tm4c/tm4c_memorymap.h:616:1: error: Missing blank line after comment
   nuttx/arch/arm/src/tiva/hardware/tm4c/tm4c_pinmap.h:1:85: error: Long line found
   ```
   If there is the unreasonable warning like "Wrong column position of comment right of code" mention in PR, we can then ignore it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2161: Added Support for more TI Tiva Microcontrollers:

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2161:
URL: https://github.com/apache/incubator-nuttx/pull/2161#issuecomment-718858016


   @fckruegel please fix the nxstyle warning here:
   https://github.com/apache/incubator-nuttx/pull/2161/checks?check_run_id=1327083440
   you can run locally too by:
   ./tools/checkpatch.sh -g HEAD~...HEAD


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2161: Added Support for more TI Tiva Microcontrollers:

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2161:
URL: https://github.com/apache/incubator-nuttx/pull/2161


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #2161: Added Support for more TI Tiva Microcontrollers:

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on pull request #2161:
URL: https://github.com/apache/incubator-nuttx/pull/2161#issuecomment-721205565


   Does anyone know why the check indicates a failure on nxstyle errors in arch/xtensa/src/esp32/esp32_spiflash.c? That file is not changed by this PR!!!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #2161: Added Support for more TI Tiva Microcontrollers:

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2161:
URL: https://github.com/apache/incubator-nuttx/pull/2161#issuecomment-721210826


   > Does anyone know why the check indicates a failure on nxstyle errors in arch/xtensa/src/esp32/esp32_spiflash.c? That file is not changed by this PR!!!
   
   It has to do with how the commits are determined on the PR. You can ignore the non relevant ones or do a rebase.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org