You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/04/11 20:15:10 UTC

[GitHub] [arrow-datafusion] alamb opened a new pull request, #5968: minor: port some expr tests to sqllogictests, improve error message

alamb opened a new pull request, #5968:
URL: https://github.com/apache/arrow-datafusion/pull/5968

   # Which issue does this PR close?
   
   Part of https://github.com/apache/arrow-datafusion/issues/4495
   
   # Rationale for this change
   1. Suggested by @comphead  as part of https://github.com/apache/arrow-datafusion/pull/5902#discussion_r1160815036 
   1. https://github.com/apache/arrow-datafusion/tree/main/datafusion/core/tests/sqllogictests#sqllogictests 
   2. I would like to evaluate test coverage in one place
   
   # What changes are included in this PR?
   1. Port some tests over
   2. Update a message from internal to plan
   
   # Are these changes tested?
   Yes
   # Are there any user-facing changes?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5968: minor: port some expr tests to sqllogictests, improve error message

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5968:
URL: https://github.com/apache/arrow-datafusion/pull/5968#discussion_r1163279892


##########
datafusion/physical-expr/src/expressions/not.rs:
##########
@@ -77,8 +77,8 @@ impl PhysicalExpr for NotExpr {
             DataType::Int32 => Ok(DataType::Int32),
             DataType::Int64 => Ok(DataType::Int64),
             DataType::Null => Ok(DataType::Null),
-            _ => Err(DataFusionError::Internal(format!(
-                "Can't NOT or BITWISE_NOT datatype: '{:?}'",
+            _ => Err(DataFusionError::Plan(format!(

Review Comment:
   This can be hit with a bad user query, so it shouldn't be an Internal error



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #5968: minor: port some expr tests to sqllogictests, improve error message

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5968:
URL: https://github.com/apache/arrow-datafusion/pull/5968#issuecomment-1507396146

   Thanks for the assist @xu


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] xudong963 merged pull request #5968: minor: port some expr tests to sqllogictests, improve error message

Posted by "xudong963 (via GitHub)" <gi...@apache.org>.
xudong963 merged PR #5968:
URL: https://github.com/apache/arrow-datafusion/pull/5968


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org