You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/11/23 00:38:45 UTC
[kudu-CR] [tests] fix flakiness in RaftConsensusITest.TestSlowFollower
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18047
Change subject: [tests] fix flakiness in RaftConsensusITest.TestSlowFollower
......................................................................
[tests] fix flakiness in RaftConsensusITest.TestSlowFollower
The results for the DEBUG build running with --stress_cpu_threads=16:
before: 7 out of 256 failed
http://dist-test.cloudera.org/job?job_id=aserbin.1637624733.12826
after : 0 out of 256 failed
http://dist-test.cloudera.org/job?job_id=aserbin.1637624357.6197
I also took the liberty of updating a few error messages to be more
concise (saw those while troubleshooting the flakiness in the test
scenario).
Change-Id: Id4b4245023935deff58ba60840c9a8a01d1da2b1
---
M src/kudu/consensus/time_manager.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
2 files changed, 25 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/18047/1
--
To view, visit http://gerrit.cloudera.org:8080/18047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4b4245023935deff58ba60840c9a8a01d1da2b1
Gerrit-Change-Number: 18047
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tests] fix flakiness in RaftConsensusITest.TestSlowFollower
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18047 )
Change subject: [tests] fix flakiness in RaftConsensusITest.TestSlowFollower
......................................................................
[tests] fix flakiness in RaftConsensusITest.TestSlowFollower
The results for the DEBUG build running with --stress_cpu_threads=16:
before: 7 out of 256 failed
http://dist-test.cloudera.org/job?job_id=aserbin.1637624733.12826
after : 0 out of 256 failed
http://dist-test.cloudera.org/job?job_id=aserbin.1637624357.6197
I also took the liberty of updating a few error messages to be more
concise (saw those while troubleshooting the flakiness in the test
scenario).
Change-Id: Id4b4245023935deff58ba60840c9a8a01d1da2b1
Reviewed-on: http://gerrit.cloudera.org:8080/18047
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/consensus/time_manager.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
2 files changed, 26 insertions(+), 12 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id4b4245023935deff58ba60840c9a8a01d1da2b1
Gerrit-Change-Number: 18047
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tests] fix flakiness in RaftConsensusITest.TestSlowFollower
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18047 )
Change subject: [tests] fix flakiness in RaftConsensusITest.TestSlowFollower
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4b4245023935deff58ba60840c9a8a01d1da2b1
Gerrit-Change-Number: 18047
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 23 Nov 2021 03:46:08 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] fix flakiness in RaftConsensusITest.TestSlowFollower
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18047
to look at the new patch set (#2).
Change subject: [tests] fix flakiness in RaftConsensusITest.TestSlowFollower
......................................................................
[tests] fix flakiness in RaftConsensusITest.TestSlowFollower
The results for the DEBUG build running with --stress_cpu_threads=16:
before: 7 out of 256 failed
http://dist-test.cloudera.org/job?job_id=aserbin.1637624733.12826
after : 0 out of 256 failed
http://dist-test.cloudera.org/job?job_id=aserbin.1637624357.6197
I also took the liberty of updating a few error messages to be more
concise (saw those while troubleshooting the flakiness in the test
scenario).
Change-Id: Id4b4245023935deff58ba60840c9a8a01d1da2b1
---
M src/kudu/consensus/time_manager.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
2 files changed, 26 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/18047/2
--
To view, visit http://gerrit.cloudera.org:8080/18047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id4b4245023935deff58ba60840c9a8a01d1da2b1
Gerrit-Change-Number: 18047
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tests] fix flakiness in RaftConsensusITest.TestSlowFollower
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [tests] fix flakiness in RaftConsensusITest.TestSlowFollower
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id4b4245023935deff58ba60840c9a8a01d1da2b1
Gerrit-Change-Number: 18047
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tests] fix flakiness in RaftConsensusITest.TestSlowFollower
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18047 )
Change subject: [tests] fix flakiness in RaftConsensusITest.TestSlowFollower
......................................................................
Patch Set 1: Code-Review+2
Thank you for addressing this long-standing flake!
--
To view, visit http://gerrit.cloudera.org:8080/18047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4b4245023935deff58ba60840c9a8a01d1da2b1
Gerrit-Change-Number: 18047
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 23 Nov 2021 00:59:56 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] fix flakiness in RaftConsensusITest.TestSlowFollower
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18047 )
Change subject: [tests] fix flakiness in RaftConsensusITest.TestSlowFollower
......................................................................
Patch Set 2: Code-Review+2
Carrying over Andrew's +2 from PS1.
--
To view, visit http://gerrit.cloudera.org:8080/18047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4b4245023935deff58ba60840c9a8a01d1da2b1
Gerrit-Change-Number: 18047
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 23 Nov 2021 03:46:00 +0000
Gerrit-HasComments: No