You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/01 10:33:39 UTC
[GitHub] [flink] twalthr opened a new pull request #16042: [FLINK-22824][connector-kafka] Drop usages of legacy planner in Kafka module
twalthr opened a new pull request #16042:
URL: https://github.com/apache/flink/pull/16042
## What is the purpose of the change
Remove references to `flink-table-planner` in all Kafka modules.
## Brief change log
Cleans up the module. However, the clean up is not completed yet. In theory we could also remove the pre FLIP-95 stack and descriptors. But this is future work.
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16042: [FLINK-22824][connector-kafka] Drop usages of legacy planner in Kafka module
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16042:
URL: https://github.com/apache/flink/pull/16042#issuecomment-852042975
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6e00abb3e49699610957accc64fb6ff73b05e357",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18505",
"triggerID" : "6e00abb3e49699610957accc64fb6ff73b05e357",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6e00abb3e49699610957accc64fb6ff73b05e357 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18505)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16042: [FLINK-22824][connector-kafka] Drop usages of legacy planner in Kafka module
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16042:
URL: https://github.com/apache/flink/pull/16042#issuecomment-852042975
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6e00abb3e49699610957accc64fb6ff73b05e357",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18505",
"triggerID" : "6e00abb3e49699610957accc64fb6ff73b05e357",
"triggerType" : "PUSH"
}, {
"hash" : "ccff72c3c9b9db586ac8383e75efb259ce6cf9f5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18556",
"triggerID" : "ccff72c3c9b9db586ac8383e75efb259ce6cf9f5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ccff72c3c9b9db586ac8383e75efb259ce6cf9f5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18556)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #16042: [FLINK-22824][connector-kafka] Drop usages of legacy planner in Kafka module
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #16042:
URL: https://github.com/apache/flink/pull/16042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16042: [FLINK-22824][connector-kafka] Drop usages of legacy planner in Kafka module
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16042:
URL: https://github.com/apache/flink/pull/16042#issuecomment-852042975
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6e00abb3e49699610957accc64fb6ff73b05e357",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18505",
"triggerID" : "6e00abb3e49699610957accc64fb6ff73b05e357",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6e00abb3e49699610957accc64fb6ff73b05e357 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18505)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16042: [FLINK-22824][connector-kafka] Drop usages of legacy planner in Kafka module
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16042:
URL: https://github.com/apache/flink/pull/16042#issuecomment-852018466
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6e00abb3e49699610957accc64fb6ff73b05e357 (Tue Jun 01 10:35:54 UTC 2021)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16042: [FLINK-22824][connector-kafka] Drop usages of legacy planner in Kafka module
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16042:
URL: https://github.com/apache/flink/pull/16042#issuecomment-852042975
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6e00abb3e49699610957accc64fb6ff73b05e357",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18505",
"triggerID" : "6e00abb3e49699610957accc64fb6ff73b05e357",
"triggerType" : "PUSH"
}, {
"hash" : "ccff72c3c9b9db586ac8383e75efb259ce6cf9f5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ccff72c3c9b9db586ac8383e75efb259ce6cf9f5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6e00abb3e49699610957accc64fb6ff73b05e357 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18505)
* ccff72c3c9b9db586ac8383e75efb259ce6cf9f5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #16042: [FLINK-22824][connector-kafka] Drop usages of legacy planner in Kafka module
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #16042:
URL: https://github.com/apache/flink/pull/16042#discussion_r643698793
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceSinkFactoryTestBase.java
##########
@@ -410,24 +414,64 @@ public void testTableSinkWithLegacyProperties() {
}
protected Map<String, String> createKafkaSinkProperties() {
- return new TestTableDescriptor(
- new Kafka()
- .version(getKafkaVersion())
- .topic(TOPIC)
- .properties(KAFKA_PROPERTIES)
- .sinkPartitionerFixed()
- .startFromSpecificOffsets(
- OFFSETS)) // test if they accepted although not needed
- .withFormat(new TestTableFormat())
- .withSchema(
- new Schema()
- .field(FRUIT_NAME, DataTypes.STRING())
- .field(COUNT, DataTypes.DECIMAL(10, 4))
- .field(EVENT_TIME, DataTypes.TIMESTAMP(3)))
- .inAppendMode()
- .toProperties();
+ final Map<String, String> map = new HashMap<>();
+ map.put("schema.0.data-type", "VARCHAR(2147483647)");
Review comment:
this is just the generated output from the removed code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16042: [FLINK-22824][connector-kafka] Drop usages of legacy planner in Kafka module
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16042:
URL: https://github.com/apache/flink/pull/16042#issuecomment-852018466
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ccff72c3c9b9db586ac8383e75efb259ce6cf9f5 (Sat Aug 28 12:15:04 UTC 2021)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16042: [FLINK-22824][connector-kafka] Drop usages of legacy planner in Kafka module
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16042:
URL: https://github.com/apache/flink/pull/16042#issuecomment-852042975
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6e00abb3e49699610957accc64fb6ff73b05e357",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18505",
"triggerID" : "6e00abb3e49699610957accc64fb6ff73b05e357",
"triggerType" : "PUSH"
}, {
"hash" : "ccff72c3c9b9db586ac8383e75efb259ce6cf9f5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18556",
"triggerID" : "ccff72c3c9b9db586ac8383e75efb259ce6cf9f5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6e00abb3e49699610957accc64fb6ff73b05e357 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18505)
* ccff72c3c9b9db586ac8383e75efb259ce6cf9f5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18556)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16042: [FLINK-22824][connector-kafka] Drop usages of legacy planner in Kafka module
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16042:
URL: https://github.com/apache/flink/pull/16042#issuecomment-852042975
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6e00abb3e49699610957accc64fb6ff73b05e357",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6e00abb3e49699610957accc64fb6ff73b05e357",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6e00abb3e49699610957accc64fb6ff73b05e357 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Airblader commented on a change in pull request #16042: [FLINK-22824][connector-kafka] Drop usages of legacy planner in Kafka module
Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #16042:
URL: https://github.com/apache/flink/pull/16042#discussion_r643694710
##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceSinkFactoryTestBase.java
##########
@@ -410,24 +414,64 @@ public void testTableSinkWithLegacyProperties() {
}
protected Map<String, String> createKafkaSinkProperties() {
- return new TestTableDescriptor(
- new Kafka()
- .version(getKafkaVersion())
- .topic(TOPIC)
- .properties(KAFKA_PROPERTIES)
- .sinkPartitionerFixed()
- .startFromSpecificOffsets(
- OFFSETS)) // test if they accepted although not needed
- .withFormat(new TestTableFormat())
- .withSchema(
- new Schema()
- .field(FRUIT_NAME, DataTypes.STRING())
- .field(COUNT, DataTypes.DECIMAL(10, 4))
- .field(EVENT_TIME, DataTypes.TIMESTAMP(3)))
- .inAppendMode()
- .toProperties();
+ final Map<String, String> map = new HashMap<>();
+ map.put("schema.0.data-type", "VARCHAR(2147483647)");
Review comment:
nit: why not `STRING`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #16042: [FLINK-22824][connector-kafka] Drop usages of legacy planner in Kafka module
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #16042:
URL: https://github.com/apache/flink/pull/16042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org