[jira] [Created] (HDFS-14294) Deprecate DFSUtilClient#getSmallBufferSize

["BELUGA BEHR (JIRA)" <ji...@apache.org>]

BELUGA BEHR created HDFS-14294:
----------------------------------

             Summary: Deprecate DFSUtilClient#getSmallBufferSize
                 Key: HDFS-14294
                 URL: https://issues.apache.org/jira/browse/HDFS-14294
             Project: Hadoop HDFS
          Issue Type: Improvement
          Components: hdfs
    Affects Versions: 3.2.0
            Reporter: BELUGA BEHR


{code:java|title=DFSUtilClient.java}
  public static int getIoFileBufferSize(Configuration conf) {
    return conf.getInt(
        CommonConfigurationKeysPublic.IO_FILE_BUFFER_SIZE_KEY,
        CommonConfigurationKeysPublic.IO_FILE_BUFFER_SIZE_DEFAULT);
  }

 public static int getSmallBufferSize(Configuration conf) {
    return Math.min(getIoFileBufferSize(conf) / 2, 512);
  }
{code}
This concept of a "small buffer size" seems a bit overkill. First of all, it's not documented that such a thing exists and that by adjusting {{dfs.stream-buffer-size}} an administrator is also scaling these other buffer sizes. Seconds, I think any "small" buffer size should just use the default JDK buffer sizes. Anything that benefits from being larger than the default JDK size should be the controlled by {{IO_FILE_BUFFER_SIZE_KEY}} / {{dfs.stream-buffer-size}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org