svn commit: r818192 - in /myfaces/core/trunk: api/src/main/java/javax/faces/component/UIComponent.java impl/src/main/java/org/apache/myfaces/view/facelets/DefaultFaceletsStateManagementStrategy.java

[we...@apache.org]

Author: werpu
Date: Wed Sep 23 18:42:13 2009
New Revision: 818192

URL: http://svn.apache.org/viewvc?rev=818192&view=rev
Log:
https://issues.apache.org/jira/browse/MYFACES-2361

reverting the changes until it is cleared up with the EG regarding the event






Modified:
    myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponent.java
    myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/DefaultFaceletsStateManagementStrategy.java

Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponent.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponent.java?rev=818192&r1=818191&r2=818192&view=diff
==============================================================================
--- myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponent.java (original)
+++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponent.java Wed Sep 23 18:42:13 2009
@@ -594,7 +594,9 @@
             //but a quick blackbox test against the ri revealed that the event clearly is dispatched
             //at restore level for every component so we either issue it here or in UIViewRoot and/or the facelet
             // and jsp restore state triggers, a central point is preferrble so we do it here
-            getFacesContext().getApplication().publishEvent(getFacesContext(), PostRestoreStateEvent.class, UIComponent.class, this);
+            //TODO ask the EG the spec clearly contradicts blackbox RI behavior here 
+
+           //getFacesContext().getApplication().publishEvent(getFacesContext(), PostRestoreStateEvent.class, UIComponent.class, this);
         }
 
     }

Modified: myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/DefaultFaceletsStateManagementStrategy.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/DefaultFaceletsStateManagementStrategy.java?rev=818192&r1=818191&r2=818192&view=diff
==============================================================================
--- myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/DefaultFaceletsStateManagementStrategy.java (original)
+++ myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/DefaultFaceletsStateManagementStrategy.java Wed Sep 23 18:42:13 2009
@@ -229,14 +229,17 @@
         }
         
         // Restore binding, because UIViewRoot.processRestoreState() is never called
-        boolean oldContextEventState = context.isProcessingEvents();
+        //boolean oldContextEventState = context.isProcessingEvents();
         //the event processing has to be enabled because of the restore view event triggers
-        context.setProcessingEvents(true);
-        try {
+        //TODO ask the EG the this is a spec violation if we do it that way
+        //see Section 2.2.1 
+
+        //context.setProcessingEvents(true);
+        //try {
             view.visitTree(VisitContext.createVisitContext(context), new RestoreStateCallback());
-        } finally {
-            context.setProcessingEvents(oldContextEventState);
-        }
+        //} finally {
+        //    context.setProcessingEvents(oldContextEventState);
+        //}
         return view;
     }