[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15917: [improvement](scan) Support pushdown execute expr ctx

[GitBox <gi...@apache.org>]

github-actions[bot] commented on code in PR #15917:
URL: https://github.com/apache/doris/pull/15917#discussion_r1069466472


##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1107,7 +1140,7 @@ void SegmentIterator::_init_current_block(
             i >= block->columns()) { //todo(wb) maybe we can release it after output block
             current_columns[cid]->clear();
         } else { // non-predicate column
-            current_columns[cid] = std::move(*block->get_by_position(i).column).mutate();
+            current_columns[cid] = std::move(*block->get_by_position(i).column).assume_mutable();

Review Comment:
   warning: std::move of the const expression has no effect; remove std::move() [performance-move-const-arg]
   
   ```suggestion
               current_columns[cid] = *block->get_by_position(i).column.assume_mutable();
   ```
   



##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1414,6 +1481,115 @@
     return Status::OK();
 }
 
+uint16_t SegmentIterator::_execute_remaining_expr(uint16_t* sel_rowid_idx, uint16_t selected_size,
+                                                  vectorized::Block* block) {
+    if (_remaining_vconjunct_root != nullptr && block->rows() != 0) {
+        size_t prev_columns = block->columns();
+        int result_column_id = -1;
+        RETURN_IF_ERROR(_remaining_vconjunct_ctx->execute(block, &result_column_id));
+        vectorized::ColumnPtr filter_column = block->get_by_position(result_column_id).column;
+        if (auto* nullable_column =
+                    vectorized::check_and_get_column<vectorized::ColumnNullable>(*filter_column)) {
+            vectorized::ColumnPtr nested_column = nullable_column->get_nested_column_ptr();
+
+            vectorized::MutableColumnPtr mutable_holder =
+                    nested_column->use_count() == 1
+                            ? nested_column->assume_mutable()
+                            : nested_column->clone_resized(nested_column->size());
+
+            vectorized::ColumnUInt8* concrete_column =
+                    typeid_cast<vectorized::ColumnUInt8*>(mutable_holder.get());
+            if (!concrete_column) {
+                return Status::InvalidArgument(
+                        "Illegal type {} of column for filter. Must be UInt8 or Nullable(UInt8).",
+                        filter_column->get_name());
+            }
+            auto* __restrict null_map = nullable_column->get_null_map_data().data();
+            vectorized::IColumn::Filter& filter = concrete_column->get_data();
+            auto* __restrict filter_data = filter.data();
+
+            const size_t size = filter.size();
+            for (size_t i = 0; i < size; ++i) {
+                filter_data[i] &= !null_map[i];
+            }
+
+            selected_size = _evaluate_remaining_expr_filter(sel_rowid_idx, selected_size, filter);
+            vectorized::Block::filter_block_internal(block, _columns_to_filter, filter);
+        } else if (auto* const_column = vectorized::check_and_get_column<vectorized::ColumnConst>(
+                           *filter_column)) {
+            bool ret = const_column->get_bool(0);
+            if (!ret) {
+                selected_size = 0;
+                for (auto& col : _columns_to_filter) {
+                    std::move(*block->get_by_position(col).column).assume_mutable()->clear();

Review Comment:
   warning: std::move of the const expression has no effect; remove std::move() [performance-move-const-arg]
   
   ```suggestion
                       *block->get_by_position(col).column.assume_mutable()->clear();
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org