You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/26 08:41:45 UTC

[GitHub] [flink] lirui-apache commented on a change in pull request #11215: [FLINK-16275][table-planner-blink] AggsHandlerCodeGenerator can fail …

lirui-apache commented on a change in pull request #11215: [FLINK-16275][table-planner-blink] AggsHandlerCodeGenerator can fail …
URL: https://github.com/apache/flink/pull/11215#discussion_r384341569
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/agg/AggsHandlerCodeGenerator.scala
 ##########
 @@ -333,6 +333,10 @@ class AggsHandlerCodeGenerator(
 
     val functionName = newName(name)
 
+    // make sure we can get the RuntimeContext properly
+    val openCode = ctx.reuseOpenCode().replaceAll("\\(getRuntimeContext\\(\\)\\)",
 
 Review comment:
   I thought it's simpler this way, since we only need get the RuntimeContext in the open method. I'll add a `getRuntimeContext` method if you think that's better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services