You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/11/03 10:34:01 UTC
[GitHub] [netbeans] sdedic opened a new pull request, #4907: Fixes for DialogNotifier in LSP
sdedic opened a new pull request, #4907:
URL: https://github.com/apache/netbeans/pull/4907
The main issue fixed is the binding between LSP `UIContext` and the **first client that initializes it** and then is stuck with it. The original code gave the 1st client the priority over the client that may have been present in the computational context `Lookup.getDefault()`. The changed code will use the current Lookup.getDefault() that is transferred through various RP.Tasks - this is already implemented in UIContext.find()
* fixes ADM report, so it uses fire-and-forge `notifyLater` instead `notify`. The LSP client may use modeless UI (vscode does) and the server thread is left blocked until the user dismisses the report (in vscode the user may just ignore it or hide it into status line without dismissing)
* minor fix for tests: the structure must gson-deserialize on JDK11, so default ctor + setters are needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #4907: Fixes for DialogNotifier in LSP
Posted by GitBox <gi...@apache.org>.
sdedic merged PR #4907:
URL: https://github.com/apache/netbeans/pull/4907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists