You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/12/05 22:41:08 UTC

[GitHub] [incubator-yunikorn-web] wilfred-s opened a new pull request #66: [YUNIKORN-964] upgrade image base to 1.21.4-alpine

wilfred-s opened a new pull request #66:
URL: https://github.com/apache/incubator-yunikorn-web/pull/66


   Fix vulnerabilities in the base image by moving to later version.
   
   ### What is this PR for?
   Upgrade the docker base image to fix OS vulnerabilities.
   
   ### What type of PR is it?
   * [X ] - Bug Fix
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/YUNIKORN-964
   
   ### How should this be tested?
   any build and deploy will use the new image
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   NA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-yunikorn-web] yuchaoran2011 commented on pull request #66: [YUNIKORN-964] upgrade image base to 1.21.4-alpine

Posted by GitBox <gi...@apache.org>.
yuchaoran2011 commented on pull request #66:
URL: https://github.com/apache/incubator-yunikorn-web/pull/66#issuecomment-986317664


   CI is failing with the error:
   ```
   Node.js version v12.14.1 detected.
   The Angular CLI requires a minimum Node.js version of either v12.20, v14.15, or v16.10.
   ```
   Not sure where `12.14.1` in the above message came from. But the node version in the base image is 12.13.1, which needs to be bumped up
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-yunikorn-web] yuchaoran2011 merged pull request #66: [YUNIKORN-964] upgrade image base to 1.21.4-alpine

Posted by GitBox <gi...@apache.org>.
yuchaoran2011 merged pull request #66:
URL: https://github.com/apache/incubator-yunikorn-web/pull/66


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-yunikorn-web] wilfred-s commented on pull request #66: [YUNIKORN-964] upgrade image base to 1.21.4-alpine

Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #66:
URL: https://github.com/apache/incubator-yunikorn-web/pull/66#issuecomment-986364406


   The 12.14.1 comes from the github action. The real make image build runs from the Dockerfile only. We need to update both of them. We should never have been out of sync between the github action and the Dockerfile. I will correct that too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org