[GitHub] [cloudstack] kioie opened a new pull request #3412: Allow for the "Update VM Hostname" button to be included in VM options when VM is switched off

[GitBox <gi...@apache.org>]

kioie opened a new pull request #3412: Allow for the "Update VM Hostname" button to be included in VM options when VM is switched off
URL: https://github.com/apache/cloudstack/pull/3412
 
 
   
   
   ## Description
   <!--- Describe your changes in detail -->
   This is a feature that allows end users to be able to change the hostname of their VM and the, if the vm.instancename.flag under the Global Settings is set to true
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   ![Screen Shot 2019-06-20 at 9 33 28 PM](https://user-images.githubusercontent.com/20902920/59872919-80b7eb00-93a3-11e9-85a1-a58b06b01e7f.png)
   
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
    Changed the vm.instancename.flag under the Global Settings to false to see if the VM hostname would still change
   
    Changed the  vm.instancename.flag under the Global Settings to true to see if the VM hostname would change.
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services