[GitHub] [superset] simchaNielsen commented on pull request #12465: fix(native-filters): Setting default value

[GitBox <gi...@apache.org>]

simchaNielsen commented on pull request #12465:
URL: https://github.com/apache/superset/pull/12465#issuecomment-768230601


   Hi it looks good work 👍 
   I have some question about implementation. I see you use `Select` to choose defaultValue but we have different native filters chart types, for example for now we have already implemented `Range` native filter, so I think in this case we can't use `Select` to select appropriate value.
   
   So I think it can be better use SuperChart here to inject appropriate value selection for default value, I had some PR for it but closed it in favour of yours, because you also implemented it in different way... but I still think that it can be good to use SuperChart here to select default value:
   https://github.com/apache/superset/pull/12199
   cc @villebro thoughts?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org