You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2018/01/18 00:16:21 UTC
Re: Review Request 65197: Added some missing email addresses to the
contributors list.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65197/
-----------------------------------------------------------
(Updated Jan. 17, 2018, 4:16 p.m.)
Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, Benjamin Hindman, Greg Mann, and Joseph Wu.
Changes
-------
Added moar email addresses!
Summary (updated)
-----------------
Added some missing email addresses to the contributors list.
Repository: mesos
Description (updated)
-------
Added some missing email addresses to the contributors list.
Diffs (updated)
-----
docs/contributors.yaml 8bfeb89a9dea3de424b454dc0958515bb855f455
Diff: https://reviews.apache.org/r/65197/diff/2/
Changes: https://reviews.apache.org/r/65197/diff/1-2/
Testing
-------
Thanks,
Gaston Kleiman
Re: Review Request 65197: Added some missing email addresses to the
contributors list.
Posted by Armand Grillet <ag...@mesosphere.io>.
> On Jan. 18, 2018, 12:23 a.m., Joseph Wu wrote:
> > docs/contributors.yaml
> > Lines 118 (patched)
> > <https://reviews.apache.org/r/65197/diff/2/?file=1941385#file1941385line118>
> >
> > Only one here too:
> > ```
> > commit 30f7f3e1965885406d6d3e49348bee7e7d0df9d5
> > Author: Armand Grillet <Ar...@users.noreply.github.com>
> > Date: Mon Feb 6 22:45:43 2017 +0800
> >
> > Optimized the size of the favicon.
> >
> > The favicon now only contains two images: 16x16 and 32x32 (for Retina
> > displays). The size has reduced from 364 KB to 8 KB.
> >
> > This closes #202
> > ```
> >
> > And both are Github PRs :|
Please don't list me with that email address, it adds noise in my opinion.
- Armand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65197/#review195670
-----------------------------------------------------------
On Jan. 18, 2018, 12:16 a.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65197/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2018, 12:16 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, Benjamin Hindman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added some missing email addresses to the contributors list.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 8bfeb89a9dea3de424b454dc0958515bb855f455
>
>
> Diff: https://reviews.apache.org/r/65197/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 65197: Added some missing email addresses to the
contributors list.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
> On Jan. 17, 2018, 4:23 p.m., Joseph Wu wrote:
> > Hum... so of those email addresses are unfortunate... I suppose it's up to Andrei and Armand if they want to have those listed.
> >
> > Everything else looks good though.
Yeah, I am not very sure about those temporary email addreses.
I added them, because I used `contributors.yaml` to generate some stats, and I wanted to make them as accurate as possible. But I also think that they add noise to the file, so I'd be ok removing them from the patch.
- Gaston
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65197/#review195670
-----------------------------------------------------------
On Jan. 17, 2018, 4:16 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65197/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2018, 4:16 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, Benjamin Hindman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added some missing email addresses to the contributors list.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 8bfeb89a9dea3de424b454dc0958515bb855f455
>
>
> Diff: https://reviews.apache.org/r/65197/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 65197: Added some missing email addresses to the
contributors list.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65197/#review195670
-----------------------------------------------------------
Ship it!
Hum... so of those email addresses are unfortunate... I suppose it's up to Andrei and Armand if they want to have those listed.
Everything else looks good though.
docs/contributors.yaml
Lines 84 (patched)
<https://reviews.apache.org/r/65197/#comment274937>
Looks like there's only one commit with this email:
```
commit 10bdcdc77cad097866055256255d8857dd4fadd3
Author: Budnik Andrei <ab...@Budniks-MacBook-Pro.local>
Date: Tue May 2 14:20:57 2017 +0200
Added Andrei Budnik to the contributors list.
This closes #209
```
docs/contributors.yaml
Lines 118 (patched)
<https://reviews.apache.org/r/65197/#comment274938>
Only one here too:
```
commit 30f7f3e1965885406d6d3e49348bee7e7d0df9d5
Author: Armand Grillet <Ar...@users.noreply.github.com>
Date: Mon Feb 6 22:45:43 2017 +0800
Optimized the size of the favicon.
The favicon now only contains two images: 16x16 and 32x32 (for Retina
displays). The size has reduced from 364 KB to 8 KB.
This closes #202
```
And both are Github PRs :|
- Joseph Wu
On Jan. 17, 2018, 4:16 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65197/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2018, 4:16 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, Benjamin Hindman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added some missing email addresses to the contributors list.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 8bfeb89a9dea3de424b454dc0958515bb855f455
>
>
> Diff: https://reviews.apache.org/r/65197/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 65197: Added some missing email addresses to the
contributors list.
Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65197/#review195705
-----------------------------------------------------------
Ship it!
Ship It!
- Andrei Budnik
On Jan. 18, 2018, 12:16 a.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65197/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2018, 12:16 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, Benjamin Hindman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added some missing email addresses to the contributors list.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 8bfeb89a9dea3de424b454dc0958515bb855f455
>
>
> Diff: https://reviews.apache.org/r/65197/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 65197: Added some missing email addresses to the
contributors list.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65197/#review195679
-----------------------------------------------------------
PASS: Mesos patch 65197 was successfully built and tested.
Reviews applied: `['65197']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65197
- Mesos Reviewbot Windows
On Jan. 18, 2018, 12:16 a.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65197/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2018, 12:16 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, Benjamin Hindman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added some missing email addresses to the contributors list.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 8bfeb89a9dea3de424b454dc0958515bb855f455
>
>
> Diff: https://reviews.apache.org/r/65197/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 65197: Added some missing email addresses to the
contributors list.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65197/#review195994
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On Jan. 22, 2018, 8:45 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65197/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2018, 8:45 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, Benjamin Hindman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added some missing email addresses to the contributors list.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 8fc6d2bafaa8bef9ea6957e6d352de371e358f1d
>
>
> Diff: https://reviews.apache.org/r/65197/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 65197: Added some missing email addresses to the
contributors list.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65197/#review195993
-----------------------------------------------------------
PASS: Mesos patch 65197 was successfully built and tested.
Reviews applied: `['65197']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65197
- Mesos Reviewbot Windows
On Jan. 22, 2018, 8:45 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65197/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2018, 8:45 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, Benjamin Hindman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added some missing email addresses to the contributors list.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 8fc6d2bafaa8bef9ea6957e6d352de371e358f1d
>
>
> Diff: https://reviews.apache.org/r/65197/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 65197: Added some missing email addresses to the
contributors list.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65197/#review195939
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Jan. 22, 2018, 8:45 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65197/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2018, 8:45 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, Benjamin Hindman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added some missing email addresses to the contributors list.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 8fc6d2bafaa8bef9ea6957e6d352de371e358f1d
>
>
> Diff: https://reviews.apache.org/r/65197/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 65197: Added some missing email addresses to the
contributors list.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65197/
-----------------------------------------------------------
(Updated Jan. 22, 2018, 12:45 p.m.)
Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, Benjamin Hindman, Greg Mann, and Joseph Wu.
Changes
-------
Removed temporary/invalid email addresses.
Repository: mesos
Description
-------
Added some missing email addresses to the contributors list.
Diffs (updated)
-----
docs/contributors.yaml 8fc6d2bafaa8bef9ea6957e6d352de371e358f1d
Diff: https://reviews.apache.org/r/65197/diff/3/
Changes: https://reviews.apache.org/r/65197/diff/2-3/
Testing
-------
Thanks,
Gaston Kleiman