Re: [PR] test: allow external_access_plan run on windows [datafusion]

["zhuliquan (via GitHub)" <gi...@apache.org>]

zhuliquan commented on PR #13531:
URL: https://github.com/apache/datafusion/pull/13531#issuecomment-2495389426

   > we should really avoid `#[allow(dead_code)]` for stuff used only sometimes, because we won't know when this can be removed/
   > 
   > This is used in `external_access_plan` which is disabled on windows. Maybe we should try enabling it?
   
   Yeah, I enable it
   ```rust
   let new_file_name = if cfg!(target_os = "windows") {
       // Windows path separator is different from Unix
       file_name.replace("\\", "/")
   } else {
       file_name.clone()
   };
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org