You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/05/05 06:03:00 UTC
[jira] [Commented] (CB-13744) Handle storyboards as XML files
[ https://issues.apache.org/jira/browse/CB-13744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464636#comment-16464636 ]
ASF subversion and git services commented on CB-13744:
------------------------------------------------------
Commit 6fe3256fc1cf38ac482a7ff4cf8eea935628f469 in cordova-common's branch refs/heads/master from [~jcaron]
[ https://gitbox.apache.org/repos/asf?p=cordova-common.git;h=6fe3256 ]
CB-13744: Recognize storyboards as XML files
This is to allow customization of the CDVLaunchScreen.storyboard to adjust contentmode and background color in config.xml.
> Handle storyboards as XML files
> -------------------------------
>
> Key: CB-13744
> URL: https://issues.apache.org/jira/browse/CB-13744
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-common
> Reporter: Jacques Caron
> Priority: Minor
>
> When editing a file with <config-file> or <edit-config>, only a few extensions are recognised as XML, the rest are considered plists.
> The CDVLaunchScreen.storyboard generated by cordova-ios is XML. To be able to edit it from config.xml, .storyboard files need to be recognised as XML.
> Pull request: https://github.com/apache/cordova-common/pull/12
> It may make sense to take this further, and either:
> - reverse the test, and only consider .plist files to be plists, and the rest XML. Not sure if that could break something
> - or add an attribute to <config-file> and <edit-config> to specify the type of file (XML or plist).
> However for the purposes of modifying the storyboard the (very minor) change in the pull request is enough.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org