You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2017/03/08 21:12:41 UTC
[GitHub] activemq-artemis pull request #1073: AMQP changes (see commits)
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/1073
AMQP changes (see commits)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-artemis artemis-1021
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1073.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1073
----
commit 2d73f4feaf90481b8de65a54d719a2d52e764cd6
Author: Clebert Suconic <cl...@apache.org>
Date: 2017-03-08T21:11:03Z
ARTEMIS-1021 Expanding test towards other protocol types
commit c33b241b0c27eb7cab205bd3882d58c38376cba1
Author: Clebert Suconic <cl...@apache.org>
Date: 2017-03-08T21:11:35Z
ARTEMIS-1009 Tight up on AMQP
avoiding application properties even further
fixing nolocal
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1073: AMQP changes (see commits)
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1073
Fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1073: AMQP changes (see commits)
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1073#discussion_r105025094
--- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java ---
@@ -128,7 +130,7 @@ private void initalizeObjects() {
}
private Map getApplicationPropertiesMap() {
-
+ new Exception("trace").printStackTrace();
--- End diff --
oops.. not intended :)
It's my usual debug...
I will have to fix this later tonight..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1073: AMQP changes (see commits)
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1073
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1073: AMQP changes (see commits)
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1073#discussion_r105024895
--- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java ---
@@ -128,7 +130,7 @@ private void initalizeObjects() {
}
private Map getApplicationPropertiesMap() {
-
+ new Exception("trace").printStackTrace();
--- End diff --
This seems and odd thing to have in production code, is it intentional ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1073: AMQP changes (see commits)
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1073#discussion_r105046718
--- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java ---
@@ -128,7 +130,7 @@ private void initalizeObjects() {
}
private Map getApplicationPropertiesMap() {
-
+ new Exception("trace").printStackTrace();
--- End diff --
@tabish121 thanks for catching it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---