You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/09/20 07:33:38 UTC
[GitHub] [orc] guiyanakuang opened a new pull request #914: ORC-1006: Build and test in github workflow using the maven version specified in pom
guiyanakuang opened a new pull request #914:
URL: https://github.com/apache/orc/pull/914
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
Two steps have been added to the build job to set the maven version specified in pom.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
1. Make the github workflow consistent with the build environment expressed in the readme.
2. Provides a capability: github workflow facilitates switching between maven versions and even supports build testing of multiple maven versions.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Pass the CIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #914: ORC-1006: Build and test in github workflow using the maven version specified in pom
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #914:
URL: https://github.com/apache/orc/pull/914#issuecomment-923123299
Thank you for closing, @guiyanakuang .
Yes, for the unapproved ones, it may work on PR, but it's banned when we land it to the Apache branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #914: ORC-1006: Build and test in github workflow using the maven version specified in pom
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #914:
URL: https://github.com/apache/orc/pull/914#discussion_r711953237
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -40,6 +40,12 @@ jobs:
uses: actions/setup-java@v1
with:
java-version: ${{ matrix.java }}
+ - name: Set maven version to env
+ run: echo "maven_version=$(grep "<maven.version>" "./java/pom.xml" | head -n1 | awk -F '[<>]' '{print $3}')" >> $GITHUB_ENV
+ - name: Set up Maven ${{ env.maven_version }}
+ uses: stCarolas/setup-maven@v4
Review comment:
Hi, @guiyanakuang . Is it allowed by Apache Software Foundation?
AFS doesn't allow the un-approved GitHub Actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #914: ORC-1006: Build and test in github workflow using the maven version specified in pom
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #914:
URL: https://github.com/apache/orc/pull/914#discussion_r711953237
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -40,6 +40,12 @@ jobs:
uses: actions/setup-java@v1
with:
java-version: ${{ matrix.java }}
+ - name: Set maven version to env
+ run: echo "maven_version=$(grep "<maven.version>" "./java/pom.xml" | head -n1 | awk -F '[<>]' '{print $3}')" >> $GITHUB_ENV
+ - name: Set up Maven ${{ env.maven_version }}
+ uses: stCarolas/setup-maven@v4
Review comment:
Hi, @guiyanakuang . Is it approved by Apache Software Foundation?
AFS doesn't allow the un-approved GitHub Actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang closed pull request #914: ORC-1006: Build and test in github workflow using the maven version specified in pom
Posted by GitBox <gi...@apache.org>.
guiyanakuang closed pull request #914:
URL: https://github.com/apache/orc/pull/914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on a change in pull request #914: ORC-1006: Build and test in github workflow using the maven version specified in pom
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on a change in pull request #914:
URL: https://github.com/apache/orc/pull/914#discussion_r711971572
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -40,6 +40,12 @@ jobs:
uses: actions/setup-java@v1
with:
java-version: ${{ matrix.java }}
+ - name: Set maven version to env
+ run: echo "maven_version=$(grep "<maven.version>" "./java/pom.xml" | head -n1 | awk -F '[<>]' '{print $3}')" >> $GITHUB_ENV
+ - name: Set up Maven ${{ env.maven_version }}
+ uses: stCarolas/setup-maven@v4
Review comment:
Oh, I hadn't noticed that, just a moment while I make sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] guiyanakuang commented on a change in pull request #914: ORC-1006: Build and test in github workflow using the maven version specified in pom
Posted by GitBox <gi...@apache.org>.
guiyanakuang commented on a change in pull request #914:
URL: https://github.com/apache/orc/pull/914#discussion_r711998202
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -40,6 +40,12 @@ jobs:
uses: actions/setup-java@v1
with:
java-version: ${{ matrix.java }}
+ - name: Set maven version to env
+ run: echo "maven_version=$(grep "<maven.version>" "./java/pom.xml" | head -n1 | awk -F '[<>]' '{print $3}')" >> $GITHUB_ENV
+ - name: Set up Maven ${{ env.maven_version }}
+ uses: stCarolas/setup-maven@v4
Review comment:
@dongjoon-hyun I read this link: https://cwiki.apache.org/confluence/display/BUILDS/GitHub+Actions+status.
Learn about security. This pr hands over the installation of maven to a third party, which does pose a significant security risk.
> NEVER use 3rd-party actions directly in your worfklows - use the "submodule" pattern. Example PR Tobiasz Kędzierski opened in SuperSet showing how this could be done.
Although I did not find an ASF Approved Action list, I will close this pr first and open it again if I find a safe and approved solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org