You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/05/02 09:04:39 UTC

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10217: Update SQLServerDatabaseType.java fix#10126

tristaZero commented on a change in pull request #10217:
URL: https://github.com/apache/shardingsphere/pull/10217#discussion_r624659438



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/database/type/dialect/SQLServerDatabaseTypeTest.java
##########
@@ -40,7 +42,7 @@ public void assertGetName() {
     
     @Test
     public void assertGetJdbcUrlPrefixes() {
-        assertThat(new SQLServerDatabaseType().getJdbcUrlPrefixes(), is(Collections.singletonList("jdbc:microsoft:sqlserver:")));
+    	assertThat(new SQLServerDatabaseType().getJdbcUrlPrefixes(), is(new ArrayList<String>(Arrays.asList("jdbc:microsoft:sqlserver:", "jdbc:sqlserver:"))));

Review comment:
       Hi, please keep two blank spaces here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org