You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by rz...@apache.org on 2026/01/05 21:42:11 UTC

(tomee) branch xbean-4.30-SNAPSHOT updated: Remove outcommented code

This is an automated email from the ASF dual-hosted git repository.

rzo1 pushed a commit to branch xbean-4.30-SNAPSHOT
in repository https://gitbox.apache.org/repos/asf/tomee.git


The following commit(s) were added to refs/heads/xbean-4.30-SNAPSHOT by this push:
     new 33dbdbb4f4 Remove outcommented code
33dbdbb4f4 is described below

commit 33dbdbb4f4cccf5938ced5091667c1984d4178c6
Author: Richard Zowalla <rz...@apache.org>
AuthorDate: Mon Jan 5 22:42:03 2026 +0100

    Remove outcommented code
---
 .../java/org/apache/openejb/assembler/classic/Assembler.java | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java b/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
index 5be7d978db..f3d32135db 100644
--- a/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
+++ b/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
@@ -3159,20 +3159,8 @@ public class Assembler extends AssemblerTool implements org.apache.openejb.spi.A
                 }
             }
             serviceRecipe.setProperty("Definition", PropertiesHelper.propertiesToString(props));
-            //explicitly set the argument types to avoid ambiguity in factory resolution.
-//            serviceRecipe.setConstructorArgTypes(
-//                    new Class[]{
-//                            String.class, boolean.class, Class.class, String.class,
-//                            Duration.class, Duration.class, Duration.class,
-//                            boolean.class}
-//            );
         } // else: any other kind of resource relying on it? shouldnt be
 
-        //explicitly set the constructor types to avoid ambiguity in ctor resolution.
-//        if (serviceInfo.types.contains("Queue") || serviceInfo.types.contains(Queue.class.getName())) {
-//            serviceRecipe.setConstructorArgTypes(new Class[]{String.class});
-//        }
-
         replaceResourceAdapterProperty(serviceRecipe);
 
         ClassLoader loader = Thread.currentThread().getContextClassLoader();