[GitHub] [iceberg] hililiwei commented on a diff in pull request #7215: Fixed link and Add Rest catalog

["hililiwei (via GitHub)" <gi...@apache.org>]

hililiwei commented on code in PR #7215:
URL: https://github.com/apache/iceberg/pull/7215#discussion_r1152974750


##########
docs/flink-connector.md:
##########
@@ -94,7 +94,24 @@ CREATE TABLE flink_table (
 );
 ```
 
-## Table managed in custom catalog
+## Table managed in Rest catalog
+
+The following SQL will create a Flink table in current Flink catalog, which maps to the iceberg table `default_database.flink_table` managed in Rest catalog.
+
+```sql
+CREATE TABLE flink_table (
+    id   BIGINT,
+    data STRING
+) WITH (
+    'connector'='iceberg',
+    'catalog-name'='rest_prod',
+    'catalog-type'='rest',
+    'uri'='https://localhost/'
+    -- credential, token is Optional

Review Comment:
   I suggest linking to our FLink-ddl page so that users can see more optional configuration items. The same applies to Hive and Hadoop Catalog above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org