[GitHub] [doris] dataroaring commented on a diff in pull request #18640: [enhancement](storage) lazy-open necessary partitions when load

["dataroaring (via GitHub)" <gi...@apache.org>]

dataroaring commented on code in PR #18640:
URL: https://github.com/apache/doris/pull/18640#discussion_r1165254508


##########
be/src/runtime/tablets_channel.cpp:
##########
@@ -228,17 +241,24 @@ Status TabletsChannel::_open_all_writers(const PTabletWriterOpenRequest& request
     }
     if (index_slots == nullptr) {
         std::stringstream ss;
-        ss << "unknown index id, key=" << _key;
+        ss << "unknown index id, key=" << _key << " tablet_id=" << tablet_id;
         return Status::InternalError(ss.str());
     }
-    for (auto& tablet : request.tablets()) {
+    int64_t partition_id = _tablet_partition_map[tablet_id];
+    DCHECK(partition_id != 0);
+    auto tablets = _partition_tablets_map[partition_id];
+    DCHECK(tablets.size() > 0);
+    LOG(INFO) << fmt::format(

Review Comment:
   DEBUG level is enough, high frequency ingestions would leads to too many logs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org