You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "lugency (via GitHub)" <gi...@apache.org> on 2026/09/21 16:09:54 UTC

[PR] RATIS-2711. Fix double position counting and remove redundant forced assignment [ratis]

lugency opened a new pull request, #1606:
URL: https://github.com/apache/ratis/pull/1606

   ## What changes were proposed in this pull request?
   
   - Remove `LimitedInputStream#read(byte[])` to avoid counting bytes twice.
   - Remove the redundant `forced = false` assignment in `BufferedWriteChannel#flushBuffer()`.
   - Add a regression test covering direct reads and reads through `DataInputStream`.
   - Suppress the resource-leak warning in `SegmentedRaftLogReader#newInstance()`
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/RATIS-2711
   
   ## How was this patch tested?
   
   Tested locally:
   - `TestSegmentedRaftLogReader#testLimitedInputStreamPosition`
   - `TestBufferedWriteChannel#testWriteToBuffer`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2711. Fix double position counting and remove redundant forced assignment [ratis]

Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo merged PR #1606:
URL: https://github.com/apache/ratis/pull/1606


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org