You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/09 03:37:09 UTC
[GitHub] [pulsar] Technoboy- opened a new pull request #13203: Fix when deleting topic with NotFoundException, do not return to client.
Technoboy- opened a new pull request #13203:
URL: https://github.com/apache/pulsar/pull/13203
Fix #12554.
### Motivation
When deleting the topic, the user may exec cmd on broker-a, and everything goes well (means : asyncGetManagedLedgerInfo completes successfully) and decide to run `store.removeManagedLedger`, but zk data is deleted by broker-b at this time, then it will throw NotFoundException (wrap KeeperException$NoNodeException) to client.
I think this exception should treat as the delete topic action perform right.
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #13203: Fix when deleting topic with NotFoundException, do not return to client.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #13203:
URL: https://github.com/apache/pulsar/pull/13203#discussion_r765432115
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
##########
@@ -760,6 +762,12 @@ protected void checkNotNull(Object o, String errorMessage) {
}
}
+ protected boolean isNotFoundException(Exception e) {
Review comment:
```suggestion
protected boolean isManagedLedgerNotFoundException(Exception e) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #13203: Fix when deleting topic with NotFoundException, do not return to client.
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on pull request #13203:
URL: https://github.com/apache/pulsar/pull/13203#issuecomment-989769395
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #13203: Fix when deleting topic with NotFoundException, do not return to client.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #13203:
URL: https://github.com/apache/pulsar/pull/13203#discussion_r765432115
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
##########
@@ -760,6 +762,12 @@ protected void checkNotNull(Object o, String errorMessage) {
}
}
+ protected boolean isNotFoundException(Exception e) {
Review comment:
```suggestion
protected static boolean isManagedLedgerNotFoundException(Exception e) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a change in pull request #13203: Fix when deleting topic with NotFoundException, do not return to client.
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #13203:
URL: https://github.com/apache/pulsar/pull/13203#discussion_r765570022
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
##########
@@ -760,6 +762,12 @@ protected void checkNotNull(Object o, String errorMessage) {
}
}
+ protected boolean isNotFoundException(Exception e) {
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #13203: Fix when deleting topic with NotFoundException, do not return to client.
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #13203:
URL: https://github.com/apache/pulsar/pull/13203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #13203: Fix when deleting topic with NotFoundException, do not return to client.
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #13203:
URL: https://github.com/apache/pulsar/pull/13203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #13203: Fix when deleting topic with NotFoundException, do not return to client.
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on pull request #13203:
URL: https://github.com/apache/pulsar/pull/13203#issuecomment-989651170
> I think we can add a unit test with the mocked `deleteTopic` method?
Ok, add related test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org