You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by jean-frederic clere <jf...@gmail.com> on 2023/09/11 13:40:07 UTC
problem compiling
Hi,
I have:
+++
jfclere@dhcp-144-162 swoc]$ make
CXX src/bw_ip_format.lo
In file included from
/home/jfclere/trafficserver/lib/swoc/include/swoc/swoc_ip.h:16,
from src/bw_ip_format.cc:8:
/home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:892:1:
error: 'intmax_t' does not name a type; did you mean 'int8_t'?
892 | intmax_t svtoi(TextView src, TextView *parsed = nullptr, int
base = 0);
| ^~~~~~~~
| int8_t
/home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:904:1:
error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
904 | uintmax_t svtou(TextView src, TextView *parsed = nullptr, int
base = 0);
| ^~~~~~~~~
| uint8_t
/home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:922:1:
error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
922 | uintmax_t
| ^~~~~~~~~
| uint8_t
/home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:944:1:
error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
944 | uintmax_t
| ^~~~~~~~~
| uint8_t
make: *** [Makefile:783: src/bw_ip_format.lo] Error 1
+++
I am sure I am making something wrong... Any hints?
--
Cheers
Jean-Frederic
Re: [E] Re: problem compiling
Posted by jean-frederic clere <jf...@gmail.com>.
On 9/13/23 19:06, Masakazu Kitajo wrote:
> Now we only support Quiche + BoringSSL for enabling QUIC on ATS.
>
> The documentation is below. It was updated several weeks ago, so I hope it
> works.
> https://github.com/apache/trafficserver/wiki/HTTP-3-Documentation
>
> And we have a script file to build ATS with QUIC support. This is for
> convenience, and the use is optional.
> https://github.com/apache/trafficserver/blob/master/tools/build_h3_tools.sh
Thanks that works well with a Tomcat as a back-end and HTTPD server (for
the alt-svc) with FireFox but not with Chrome
Alt-Svc:
h3=":4443"; ma=60, h3-29=":4443"; ma=60
Any suggestions there? (probably some settings in chrome).
Or my test certificates are not OK for chrome...
>
> Thanks,
> Masakazu
>
> On Tue, Sep 12, 2023 at 5:16 AM jean-frederic clere <jf...@gmail.com>
> wrote:
>
>> On 9/11/23 17:07, Brian Neradt wrote:
>>> Hi jean-frederic clere,
>>>
>>> I believe these have been addressed in master already:
>>> https://github.com/apache/trafficserver/pull/9586
>>>
>>> (Note that the description points to the libswoc change for the TextView
>>> issue you mentioned.)
>>
>> When using master I had to fix:
>> +++
>> diff --git a/tests/gold_tests/chunked_encoding/Makefile.inc
>> b/tests/gold_tests/chunked_encoding/Makefile.inc
>> index b316b4b41..96e05d8b4 100644
>> --- a/tests/gold_tests/chunked_encoding/Makefile.inc
>> +++ b/tests/gold_tests/chunked_encoding/Makefile.inc
>> @@ -16,4 +16,4 @@
>>
>> noinst_PROGRAMS += gold_tests/chunked_encoding/smuggle-client
>> gold_tests_chunked_encoding_smuggle_client_SOURCES =
>> gold_tests/chunked_encoding/smuggle-client.c
>> -gold_tests_chunked_encoding_smuggle_client_LDADD = -lssl
>> +gold_tests_chunked_encoding_smuggle_client_LDADD = -lssl -lcrypto
>> +++
>>
>> I am trying QUIC, but I am stuck trying to find what to use, quiche +
>> boringssl doesn't seem to help to build a QUIC enabled TS, is there an
>> up to date doc somewhere?
>>
>>>
>>> On Mon, Sep 11, 2023 at 10:07 AM Walt Karas <wkaras@yahooinc.com.invalid
>>>
>>> wrote:
>>>
>>>> On the master branch, cstdint is already included:
>>>>
>>>>
>> https://github.com/apache/trafficserver/blob/master/lib/swoc/include/swoc/TextView.h
>>>>
>>>> On Mon, Sep 11, 2023 at 10:30 AM jean-frederic clere <jfclere@gmail.com
>>>
>>>> wrote:
>>>>
>>>>> On 9/11/23 15:59, jean-frederic clere wrote:
>>>>>> On 9/11/23 15:40, jean-frederic clere wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> I have:
>>>>>>> +++
>>>>>>> jfclere@dhcp-144-162 swoc]$ make
>>>>>>> CXX src/bw_ip_format.lo
>>>>>>> In file included from
>>>>>>> /home/jfclere/trafficserver/lib/swoc/include/swoc/swoc_ip.h:16,
>>>>>>> from src/bw_ip_format.cc:8:
>>>>>>> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:892:1:
>>>>>>> error: 'intmax_t' does not name a type; did you mean 'int8_t'?
>>>>>>> 892 | intmax_t svtoi(TextView src, TextView *parsed = nullptr,
>> int
>>>>>>> base = 0);
>>>>>>> | ^~~~~~~~
>>>>>>> | int8_t
>>>>>>> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:904:1:
>>>>>>> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
>>>>>>> 904 | uintmax_t svtou(TextView src, TextView *parsed = nullptr,
>> int
>>>>>>> base = 0);
>>>>>>> | ^~~~~~~~~
>>>>>>> | uint8_t
>>>>>>> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:922:1:
>>>>>>> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
>>>>>>> 922 | uintmax_t
>>>>>>> | ^~~~~~~~~
>>>>>>> | uint8_t
>>>>>>> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:944:1:
>>>>>>> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
>>>>>>> 944 | uintmax_t
>>>>>>> | ^~~~~~~~~
>>>>>>> | uint8_t
>>>>>>> make: *** [Makefile:783: src/bw_ip_format.lo] Error 1
>>>>>>> +++
>>>>>>>
>>>>>>> I am sure I am making something wrong... Any hints?
>>>>>>
>>>>>> The fix looks to be:
>>>>>> +++
>>>>>> [jfclere@fedora trafficserver]$ git diff .
>>>>>> diff --git a/lib/swoc/include/swoc/TextView.h
>>>>>> b/lib/swoc/include/swoc/TextView.h
>>>>>> index e1537416f..897fd7968 100644
>>>>>> --- a/lib/swoc/include/swoc/TextView.h
>>>>>> +++ b/lib/swoc/include/swoc/TextView.h
>>>>>> @@ -18,6 +18,7 @@
>>>>>> #include <string>
>>>>>> #include <string_view>
>>>>>> #include <limits>
>>>>>> +#include <stdint.h>
>>>>>>
>>>>>> #include "swoc/swoc_version.h"
>>>>>> #include "swoc/string_view_util.h"
>>>>>> +++
>>>>>> I am on fedora38.
>>>>>>
>>>>> Oops I think the same applies to:
>>>>> +++
>>>>> diff --git a/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
>>>>> b/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
>>>>> index 526199d8d..9d0394cc7 100644
>>>>> --- a/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
>>>>> +++ b/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
>>>>> @@ -22,6 +22,7 @@
>>>>> #include <vector>
>>>>> #include <cstdlib>
>>>>> #include <atomic>
>>>>> +#include <cstdint>
>>>>>
>>>>> #include <unistd.h>
>>>>> #include <sys/socket.h>
>>>>> +++
>>>>>
>>>>> --
>>>>> Cheers
>>>>>
>>>>> Jean-Frederic
>>>>>
>>>>>
>>>>
>>>
>>>
>>
>> --
>> Cheers
>>
>> Jean-Frederic
>>
>>
>
--
Cheers
Jean-Frederic
Re: [E] Re: problem compiling
Posted by Masakazu Kitajo <ma...@apache.org>.
Now we only support Quiche + BoringSSL for enabling QUIC on ATS.
The documentation is below. It was updated several weeks ago, so I hope it
works.
https://github.com/apache/trafficserver/wiki/HTTP-3-Documentation
And we have a script file to build ATS with QUIC support. This is for
convenience, and the use is optional.
https://github.com/apache/trafficserver/blob/master/tools/build_h3_tools.sh
Thanks,
Masakazu
On Tue, Sep 12, 2023 at 5:16 AM jean-frederic clere <jf...@gmail.com>
wrote:
> On 9/11/23 17:07, Brian Neradt wrote:
> > Hi jean-frederic clere,
> >
> > I believe these have been addressed in master already:
> > https://github.com/apache/trafficserver/pull/9586
> >
> > (Note that the description points to the libswoc change for the TextView
> > issue you mentioned.)
>
> When using master I had to fix:
> +++
> diff --git a/tests/gold_tests/chunked_encoding/Makefile.inc
> b/tests/gold_tests/chunked_encoding/Makefile.inc
> index b316b4b41..96e05d8b4 100644
> --- a/tests/gold_tests/chunked_encoding/Makefile.inc
> +++ b/tests/gold_tests/chunked_encoding/Makefile.inc
> @@ -16,4 +16,4 @@
>
> noinst_PROGRAMS += gold_tests/chunked_encoding/smuggle-client
> gold_tests_chunked_encoding_smuggle_client_SOURCES =
> gold_tests/chunked_encoding/smuggle-client.c
> -gold_tests_chunked_encoding_smuggle_client_LDADD = -lssl
> +gold_tests_chunked_encoding_smuggle_client_LDADD = -lssl -lcrypto
> +++
>
> I am trying QUIC, but I am stuck trying to find what to use, quiche +
> boringssl doesn't seem to help to build a QUIC enabled TS, is there an
> up to date doc somewhere?
>
> >
> > On Mon, Sep 11, 2023 at 10:07 AM Walt Karas <wkaras@yahooinc.com.invalid
> >
> > wrote:
> >
> >> On the master branch, cstdint is already included:
> >>
> >>
> https://github.com/apache/trafficserver/blob/master/lib/swoc/include/swoc/TextView.h
> >>
> >> On Mon, Sep 11, 2023 at 10:30 AM jean-frederic clere <jfclere@gmail.com
> >
> >> wrote:
> >>
> >>> On 9/11/23 15:59, jean-frederic clere wrote:
> >>>> On 9/11/23 15:40, jean-frederic clere wrote:
> >>>>> Hi,
> >>>>>
> >>>>> I have:
> >>>>> +++
> >>>>> jfclere@dhcp-144-162 swoc]$ make
> >>>>> CXX src/bw_ip_format.lo
> >>>>> In file included from
> >>>>> /home/jfclere/trafficserver/lib/swoc/include/swoc/swoc_ip.h:16,
> >>>>> from src/bw_ip_format.cc:8:
> >>>>> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:892:1:
> >>>>> error: 'intmax_t' does not name a type; did you mean 'int8_t'?
> >>>>> 892 | intmax_t svtoi(TextView src, TextView *parsed = nullptr,
> int
> >>>>> base = 0);
> >>>>> | ^~~~~~~~
> >>>>> | int8_t
> >>>>> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:904:1:
> >>>>> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
> >>>>> 904 | uintmax_t svtou(TextView src, TextView *parsed = nullptr,
> int
> >>>>> base = 0);
> >>>>> | ^~~~~~~~~
> >>>>> | uint8_t
> >>>>> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:922:1:
> >>>>> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
> >>>>> 922 | uintmax_t
> >>>>> | ^~~~~~~~~
> >>>>> | uint8_t
> >>>>> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:944:1:
> >>>>> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
> >>>>> 944 | uintmax_t
> >>>>> | ^~~~~~~~~
> >>>>> | uint8_t
> >>>>> make: *** [Makefile:783: src/bw_ip_format.lo] Error 1
> >>>>> +++
> >>>>>
> >>>>> I am sure I am making something wrong... Any hints?
> >>>>
> >>>> The fix looks to be:
> >>>> +++
> >>>> [jfclere@fedora trafficserver]$ git diff .
> >>>> diff --git a/lib/swoc/include/swoc/TextView.h
> >>>> b/lib/swoc/include/swoc/TextView.h
> >>>> index e1537416f..897fd7968 100644
> >>>> --- a/lib/swoc/include/swoc/TextView.h
> >>>> +++ b/lib/swoc/include/swoc/TextView.h
> >>>> @@ -18,6 +18,7 @@
> >>>> #include <string>
> >>>> #include <string_view>
> >>>> #include <limits>
> >>>> +#include <stdint.h>
> >>>>
> >>>> #include "swoc/swoc_version.h"
> >>>> #include "swoc/string_view_util.h"
> >>>> +++
> >>>> I am on fedora38.
> >>>>
> >>> Oops I think the same applies to:
> >>> +++
> >>> diff --git a/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
> >>> b/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
> >>> index 526199d8d..9d0394cc7 100644
> >>> --- a/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
> >>> +++ b/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
> >>> @@ -22,6 +22,7 @@
> >>> #include <vector>
> >>> #include <cstdlib>
> >>> #include <atomic>
> >>> +#include <cstdint>
> >>>
> >>> #include <unistd.h>
> >>> #include <sys/socket.h>
> >>> +++
> >>>
> >>> --
> >>> Cheers
> >>>
> >>> Jean-Frederic
> >>>
> >>>
> >>
> >
> >
>
> --
> Cheers
>
> Jean-Frederic
>
>
Re: [E] Re: problem compiling
Posted by jean-frederic clere <jf...@gmail.com>.
On 9/11/23 17:07, Brian Neradt wrote:
> Hi jean-frederic clere,
>
> I believe these have been addressed in master already:
> https://github.com/apache/trafficserver/pull/9586
>
> (Note that the description points to the libswoc change for the TextView
> issue you mentioned.)
When using master I had to fix:
+++
diff --git a/tests/gold_tests/chunked_encoding/Makefile.inc
b/tests/gold_tests/chunked_encoding/Makefile.inc
index b316b4b41..96e05d8b4 100644
--- a/tests/gold_tests/chunked_encoding/Makefile.inc
+++ b/tests/gold_tests/chunked_encoding/Makefile.inc
@@ -16,4 +16,4 @@
noinst_PROGRAMS += gold_tests/chunked_encoding/smuggle-client
gold_tests_chunked_encoding_smuggle_client_SOURCES =
gold_tests/chunked_encoding/smuggle-client.c
-gold_tests_chunked_encoding_smuggle_client_LDADD = -lssl
+gold_tests_chunked_encoding_smuggle_client_LDADD = -lssl -lcrypto
+++
I am trying QUIC, but I am stuck trying to find what to use, quiche +
boringssl doesn't seem to help to build a QUIC enabled TS, is there an
up to date doc somewhere?
>
> On Mon, Sep 11, 2023 at 10:07 AM Walt Karas <wk...@yahooinc.com.invalid>
> wrote:
>
>> On the master branch, cstdint is already included:
>>
>> https://github.com/apache/trafficserver/blob/master/lib/swoc/include/swoc/TextView.h
>>
>> On Mon, Sep 11, 2023 at 10:30 AM jean-frederic clere <jf...@gmail.com>
>> wrote:
>>
>>> On 9/11/23 15:59, jean-frederic clere wrote:
>>>> On 9/11/23 15:40, jean-frederic clere wrote:
>>>>> Hi,
>>>>>
>>>>> I have:
>>>>> +++
>>>>> jfclere@dhcp-144-162 swoc]$ make
>>>>> CXX src/bw_ip_format.lo
>>>>> In file included from
>>>>> /home/jfclere/trafficserver/lib/swoc/include/swoc/swoc_ip.h:16,
>>>>> from src/bw_ip_format.cc:8:
>>>>> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:892:1:
>>>>> error: 'intmax_t' does not name a type; did you mean 'int8_t'?
>>>>> 892 | intmax_t svtoi(TextView src, TextView *parsed = nullptr, int
>>>>> base = 0);
>>>>> | ^~~~~~~~
>>>>> | int8_t
>>>>> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:904:1:
>>>>> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
>>>>> 904 | uintmax_t svtou(TextView src, TextView *parsed = nullptr, int
>>>>> base = 0);
>>>>> | ^~~~~~~~~
>>>>> | uint8_t
>>>>> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:922:1:
>>>>> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
>>>>> 922 | uintmax_t
>>>>> | ^~~~~~~~~
>>>>> | uint8_t
>>>>> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:944:1:
>>>>> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
>>>>> 944 | uintmax_t
>>>>> | ^~~~~~~~~
>>>>> | uint8_t
>>>>> make: *** [Makefile:783: src/bw_ip_format.lo] Error 1
>>>>> +++
>>>>>
>>>>> I am sure I am making something wrong... Any hints?
>>>>
>>>> The fix looks to be:
>>>> +++
>>>> [jfclere@fedora trafficserver]$ git diff .
>>>> diff --git a/lib/swoc/include/swoc/TextView.h
>>>> b/lib/swoc/include/swoc/TextView.h
>>>> index e1537416f..897fd7968 100644
>>>> --- a/lib/swoc/include/swoc/TextView.h
>>>> +++ b/lib/swoc/include/swoc/TextView.h
>>>> @@ -18,6 +18,7 @@
>>>> #include <string>
>>>> #include <string_view>
>>>> #include <limits>
>>>> +#include <stdint.h>
>>>>
>>>> #include "swoc/swoc_version.h"
>>>> #include "swoc/string_view_util.h"
>>>> +++
>>>> I am on fedora38.
>>>>
>>> Oops I think the same applies to:
>>> +++
>>> diff --git a/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
>>> b/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
>>> index 526199d8d..9d0394cc7 100644
>>> --- a/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
>>> +++ b/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
>>> @@ -22,6 +22,7 @@
>>> #include <vector>
>>> #include <cstdlib>
>>> #include <atomic>
>>> +#include <cstdint>
>>>
>>> #include <unistd.h>
>>> #include <sys/socket.h>
>>> +++
>>>
>>> --
>>> Cheers
>>>
>>> Jean-Frederic
>>>
>>>
>>
>
>
--
Cheers
Jean-Frederic
Re: [E] Re: problem compiling
Posted by jean-frederic clere <jf...@gmail.com>.
On 9/11/23 17:07, Brian Neradt wrote:
> Hi jean-frederic clere,
>
> I believe these have been addressed in master already:
> https://github.com/apache/trafficserver/pull/9586
>
> (Note that the description points to the libswoc change for the TextView
> issue you mentioned.)
Oops sorry I was on 10-Dev not on master.
>
> On Mon, Sep 11, 2023 at 10:07 AM Walt Karas <wk...@yahooinc.com.invalid>
> wrote:
>
>> On the master branch, cstdint is already included:
>>
>> https://github.com/apache/trafficserver/blob/master/lib/swoc/include/swoc/TextView.h
>>
>> On Mon, Sep 11, 2023 at 10:30 AM jean-frederic clere <jf...@gmail.com>
>> wrote:
>>
>>> On 9/11/23 15:59, jean-frederic clere wrote:
>>>> On 9/11/23 15:40, jean-frederic clere wrote:
>>>>> Hi,
>>>>>
>>>>> I have:
>>>>> +++
>>>>> jfclere@dhcp-144-162 swoc]$ make
>>>>> CXX src/bw_ip_format.lo
>>>>> In file included from
>>>>> /home/jfclere/trafficserver/lib/swoc/include/swoc/swoc_ip.h:16,
>>>>> from src/bw_ip_format.cc:8:
>>>>> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:892:1:
>>>>> error: 'intmax_t' does not name a type; did you mean 'int8_t'?
>>>>> 892 | intmax_t svtoi(TextView src, TextView *parsed = nullptr, int
>>>>> base = 0);
>>>>> | ^~~~~~~~
>>>>> | int8_t
>>>>> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:904:1:
>>>>> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
>>>>> 904 | uintmax_t svtou(TextView src, TextView *parsed = nullptr, int
>>>>> base = 0);
>>>>> | ^~~~~~~~~
>>>>> | uint8_t
>>>>> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:922:1:
>>>>> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
>>>>> 922 | uintmax_t
>>>>> | ^~~~~~~~~
>>>>> | uint8_t
>>>>> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:944:1:
>>>>> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
>>>>> 944 | uintmax_t
>>>>> | ^~~~~~~~~
>>>>> | uint8_t
>>>>> make: *** [Makefile:783: src/bw_ip_format.lo] Error 1
>>>>> +++
>>>>>
>>>>> I am sure I am making something wrong... Any hints?
>>>>
>>>> The fix looks to be:
>>>> +++
>>>> [jfclere@fedora trafficserver]$ git diff .
>>>> diff --git a/lib/swoc/include/swoc/TextView.h
>>>> b/lib/swoc/include/swoc/TextView.h
>>>> index e1537416f..897fd7968 100644
>>>> --- a/lib/swoc/include/swoc/TextView.h
>>>> +++ b/lib/swoc/include/swoc/TextView.h
>>>> @@ -18,6 +18,7 @@
>>>> #include <string>
>>>> #include <string_view>
>>>> #include <limits>
>>>> +#include <stdint.h>
>>>>
>>>> #include "swoc/swoc_version.h"
>>>> #include "swoc/string_view_util.h"
>>>> +++
>>>> I am on fedora38.
>>>>
>>> Oops I think the same applies to:
>>> +++
>>> diff --git a/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
>>> b/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
>>> index 526199d8d..9d0394cc7 100644
>>> --- a/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
>>> +++ b/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
>>> @@ -22,6 +22,7 @@
>>> #include <vector>
>>> #include <cstdlib>
>>> #include <atomic>
>>> +#include <cstdint>
>>>
>>> #include <unistd.h>
>>> #include <sys/socket.h>
>>> +++
>>>
>>> --
>>> Cheers
>>>
>>> Jean-Frederic
>>>
>>>
>>
>
>
--
Cheers
Jean-Frederic
Re: [E] Re: problem compiling
Posted by Brian Neradt <br...@gmail.com>.
Hi jean-frederic clere,
I believe these have been addressed in master already:
https://github.com/apache/trafficserver/pull/9586
(Note that the description points to the libswoc change for the TextView
issue you mentioned.)
On Mon, Sep 11, 2023 at 10:07 AM Walt Karas <wk...@yahooinc.com.invalid>
wrote:
> On the master branch, cstdint is already included:
>
> https://github.com/apache/trafficserver/blob/master/lib/swoc/include/swoc/TextView.h
>
> On Mon, Sep 11, 2023 at 10:30 AM jean-frederic clere <jf...@gmail.com>
> wrote:
>
> > On 9/11/23 15:59, jean-frederic clere wrote:
> > > On 9/11/23 15:40, jean-frederic clere wrote:
> > >> Hi,
> > >>
> > >> I have:
> > >> +++
> > >> jfclere@dhcp-144-162 swoc]$ make
> > >> CXX src/bw_ip_format.lo
> > >> In file included from
> > >> /home/jfclere/trafficserver/lib/swoc/include/swoc/swoc_ip.h:16,
> > >> from src/bw_ip_format.cc:8:
> > >> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:892:1:
> > >> error: 'intmax_t' does not name a type; did you mean 'int8_t'?
> > >> 892 | intmax_t svtoi(TextView src, TextView *parsed = nullptr, int
> > >> base = 0);
> > >> | ^~~~~~~~
> > >> | int8_t
> > >> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:904:1:
> > >> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
> > >> 904 | uintmax_t svtou(TextView src, TextView *parsed = nullptr, int
> > >> base = 0);
> > >> | ^~~~~~~~~
> > >> | uint8_t
> > >> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:922:1:
> > >> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
> > >> 922 | uintmax_t
> > >> | ^~~~~~~~~
> > >> | uint8_t
> > >> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:944:1:
> > >> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
> > >> 944 | uintmax_t
> > >> | ^~~~~~~~~
> > >> | uint8_t
> > >> make: *** [Makefile:783: src/bw_ip_format.lo] Error 1
> > >> +++
> > >>
> > >> I am sure I am making something wrong... Any hints?
> > >
> > > The fix looks to be:
> > > +++
> > > [jfclere@fedora trafficserver]$ git diff .
> > > diff --git a/lib/swoc/include/swoc/TextView.h
> > > b/lib/swoc/include/swoc/TextView.h
> > > index e1537416f..897fd7968 100644
> > > --- a/lib/swoc/include/swoc/TextView.h
> > > +++ b/lib/swoc/include/swoc/TextView.h
> > > @@ -18,6 +18,7 @@
> > > #include <string>
> > > #include <string_view>
> > > #include <limits>
> > > +#include <stdint.h>
> > >
> > > #include "swoc/swoc_version.h"
> > > #include "swoc/string_view_util.h"
> > > +++
> > > I am on fedora38.
> > >
> > Oops I think the same applies to:
> > +++
> > diff --git a/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
> > b/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
> > index 526199d8d..9d0394cc7 100644
> > --- a/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
> > +++ b/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
> > @@ -22,6 +22,7 @@
> > #include <vector>
> > #include <cstdlib>
> > #include <atomic>
> > +#include <cstdint>
> >
> > #include <unistd.h>
> > #include <sys/socket.h>
> > +++
> >
> > --
> > Cheers
> >
> > Jean-Frederic
> >
> >
>
--
"Come to Me, all who are weary and heavy-laden, and I will
give you rest. Take My yoke upon you and learn from Me, for
I am gentle and humble in heart, and you will find rest for
your souls. For My yoke is easy and My burden is light."
~ Matthew 11:28-30
Re: [E] Re: problem compiling
Posted by Walt Karas <wk...@yahooinc.com.INVALID>.
On the master branch, cstdint is already included:
https://github.com/apache/trafficserver/blob/master/lib/swoc/include/swoc/TextView.h
On Mon, Sep 11, 2023 at 10:30 AM jean-frederic clere <jf...@gmail.com>
wrote:
> On 9/11/23 15:59, jean-frederic clere wrote:
> > On 9/11/23 15:40, jean-frederic clere wrote:
> >> Hi,
> >>
> >> I have:
> >> +++
> >> jfclere@dhcp-144-162 swoc]$ make
> >> CXX src/bw_ip_format.lo
> >> In file included from
> >> /home/jfclere/trafficserver/lib/swoc/include/swoc/swoc_ip.h:16,
> >> from src/bw_ip_format.cc:8:
> >> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:892:1:
> >> error: 'intmax_t' does not name a type; did you mean 'int8_t'?
> >> 892 | intmax_t svtoi(TextView src, TextView *parsed = nullptr, int
> >> base = 0);
> >> | ^~~~~~~~
> >> | int8_t
> >> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:904:1:
> >> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
> >> 904 | uintmax_t svtou(TextView src, TextView *parsed = nullptr, int
> >> base = 0);
> >> | ^~~~~~~~~
> >> | uint8_t
> >> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:922:1:
> >> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
> >> 922 | uintmax_t
> >> | ^~~~~~~~~
> >> | uint8_t
> >> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:944:1:
> >> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
> >> 944 | uintmax_t
> >> | ^~~~~~~~~
> >> | uint8_t
> >> make: *** [Makefile:783: src/bw_ip_format.lo] Error 1
> >> +++
> >>
> >> I am sure I am making something wrong... Any hints?
> >
> > The fix looks to be:
> > +++
> > [jfclere@fedora trafficserver]$ git diff .
> > diff --git a/lib/swoc/include/swoc/TextView.h
> > b/lib/swoc/include/swoc/TextView.h
> > index e1537416f..897fd7968 100644
> > --- a/lib/swoc/include/swoc/TextView.h
> > +++ b/lib/swoc/include/swoc/TextView.h
> > @@ -18,6 +18,7 @@
> > #include <string>
> > #include <string_view>
> > #include <limits>
> > +#include <stdint.h>
> >
> > #include "swoc/swoc_version.h"
> > #include "swoc/string_view_util.h"
> > +++
> > I am on fedora38.
> >
> Oops I think the same applies to:
> +++
> diff --git a/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
> b/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
> index 526199d8d..9d0394cc7 100644
> --- a/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
> +++ b/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
> @@ -22,6 +22,7 @@
> #include <vector>
> #include <cstdlib>
> #include <atomic>
> +#include <cstdint>
>
> #include <unistd.h>
> #include <sys/socket.h>
> +++
>
> --
> Cheers
>
> Jean-Frederic
>
>
Re: problem compiling
Posted by jean-frederic clere <jf...@gmail.com>.
On 9/11/23 15:59, jean-frederic clere wrote:
> On 9/11/23 15:40, jean-frederic clere wrote:
>> Hi,
>>
>> I have:
>> +++
>> jfclere@dhcp-144-162 swoc]$ make
>> CXX src/bw_ip_format.lo
>> In file included from
>> /home/jfclere/trafficserver/lib/swoc/include/swoc/swoc_ip.h:16,
>> from src/bw_ip_format.cc:8:
>> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:892:1:
>> error: 'intmax_t' does not name a type; did you mean 'int8_t'?
>> 892 | intmax_t svtoi(TextView src, TextView *parsed = nullptr, int
>> base = 0);
>> | ^~~~~~~~
>> | int8_t
>> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:904:1:
>> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
>> 904 | uintmax_t svtou(TextView src, TextView *parsed = nullptr, int
>> base = 0);
>> | ^~~~~~~~~
>> | uint8_t
>> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:922:1:
>> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
>> 922 | uintmax_t
>> | ^~~~~~~~~
>> | uint8_t
>> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:944:1:
>> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
>> 944 | uintmax_t
>> | ^~~~~~~~~
>> | uint8_t
>> make: *** [Makefile:783: src/bw_ip_format.lo] Error 1
>> +++
>>
>> I am sure I am making something wrong... Any hints?
>
> The fix looks to be:
> +++
> [jfclere@fedora trafficserver]$ git diff .
> diff --git a/lib/swoc/include/swoc/TextView.h
> b/lib/swoc/include/swoc/TextView.h
> index e1537416f..897fd7968 100644
> --- a/lib/swoc/include/swoc/TextView.h
> +++ b/lib/swoc/include/swoc/TextView.h
> @@ -18,6 +18,7 @@
> #include <string>
> #include <string_view>
> #include <limits>
> +#include <stdint.h>
>
> #include "swoc/swoc_version.h"
> #include "swoc/string_view_util.h"
> +++
> I am on fedora38.
>
Oops I think the same applies to:
+++
diff --git a/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
b/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
index 526199d8d..9d0394cc7 100644
--- a/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
+++ b/tests/gold_tests/pluginTest/TSVConnFd/TSVConnFd.cc
@@ -22,6 +22,7 @@
#include <vector>
#include <cstdlib>
#include <atomic>
+#include <cstdint>
#include <unistd.h>
#include <sys/socket.h>
+++
--
Cheers
Jean-Frederic
Re: problem compiling
Posted by jean-frederic clere <jf...@gmail.com>.
On 9/11/23 15:40, jean-frederic clere wrote:
> Hi,
>
> I have:
> +++
> jfclere@dhcp-144-162 swoc]$ make
> CXX src/bw_ip_format.lo
> In file included from
> /home/jfclere/trafficserver/lib/swoc/include/swoc/swoc_ip.h:16,
> from src/bw_ip_format.cc:8:
> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:892:1:
> error: 'intmax_t' does not name a type; did you mean 'int8_t'?
> 892 | intmax_t svtoi(TextView src, TextView *parsed = nullptr, int
> base = 0);
> | ^~~~~~~~
> | int8_t
> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:904:1:
> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
> 904 | uintmax_t svtou(TextView src, TextView *parsed = nullptr, int
> base = 0);
> | ^~~~~~~~~
> | uint8_t
> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:922:1:
> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
> 922 | uintmax_t
> | ^~~~~~~~~
> | uint8_t
> /home/jfclere/trafficserver/lib/swoc/include/swoc/TextView.h:944:1:
> error: 'uintmax_t' does not name a type; did you mean 'uint8_t'?
> 944 | uintmax_t
> | ^~~~~~~~~
> | uint8_t
> make: *** [Makefile:783: src/bw_ip_format.lo] Error 1
> +++
>
> I am sure I am making something wrong... Any hints?
The fix looks to be:
+++
[jfclere@fedora trafficserver]$ git diff .
diff --git a/lib/swoc/include/swoc/TextView.h
b/lib/swoc/include/swoc/TextView.h
index e1537416f..897fd7968 100644
--- a/lib/swoc/include/swoc/TextView.h
+++ b/lib/swoc/include/swoc/TextView.h
@@ -18,6 +18,7 @@
#include <string>
#include <string_view>
#include <limits>
+#include <stdint.h>
#include "swoc/swoc_version.h"
#include "swoc/string_view_util.h"
+++
I am on fedora38.
--
Cheers
Jean-Frederic