You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/01/26 20:00:02 UTC

[GitHub] merlimat commented on a change in pull request #1097: Validate expected types in Python code wrapper

merlimat commented on a change in pull request #1097: Validate expected types in Python code wrapper
URL: https://github.com/apache/incubator-pulsar/pull/1097#discussion_r164208941
 
 

 ##########
 File path: pulsar-client-cpp/python/pulsar.py
 ##########
 @@ -185,6 +185,10 @@ def __init__(self, dynamicLibPath, authParamsString):
         * `authParamsString`: Comma-separated list of provider-specific
           configuration params
         """
+        if type(dynamicLibPath) is not str:
 
 Review comment:
   Good point, there are a couple of variations, since some argument can also be `None` and that's ok, but that would shorten the code. I'll change it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services