[GitHub] nifi pull request #2686: NIFI-5166 - Deep learning classification and regres...

[ijokarumawak <gi...@git.apache.org>]

Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2686#discussion_r193622053
  
    --- Diff: nifi-assembly/pom.xml ---
    @@ -379,6 +379,12 @@ language governing permissions and limitations under the License. -->
                 <version>1.7.0-SNAPSHOT</version>
                 <type>nar</type>
             </dependency>
    +        <dependency>
    +            <groupId>org.apache.nifi</groupId>
    +            <artifactId>nifi-deeplearning4j-nar</artifactId>
    +            <version>1.7.0-SNAPSHOT</version>
    +            <type>nar</type>
    +        </dependency>
    --- End diff --
    
    The result nifi-deeplearning4j-nar-1.7.0-SNAPSHOT.nar is quite huge in size, about 3GB. By looking at the bundled dependencies, it contains lots of jars built for specific OS, for example:
    ```
    6516020 | nd4j-native-1.0.0-alpha-android-arm.jar
    6993768 | nd4j-native-1.0.0-alpha-android-arm64.jar
    9270711 | nd4j-native-1.0.0-alpha-android-x86.jar
    8064383 | nd4j-native-1.0.0-alpha-android-x86_64.jar
    5175162 | nd4j-native-1.0.0-alpha-ios-arm64.jar
    6077149 | nd4j-native-1.0.0-alpha-ios-x86_64.jar
    5677978 | nd4j-native-1.0.0-alpha-linux-ppc64le.jar
    7305963 | nd4j-native-1.0.0-alpha-linux-x86_64.jar
    8246215 | nd4j-native-1.0.0-alpha-macosx-x86_64.jar
    8149497 | nd4j-native-1.0.0-alpha-windows-x86_64.jar
    ```
    
    We should try to reduce the nar size, otherwise we can't bundle it as a standard release binary. Need to enable nifi-deeplearning4j-nar only if user needs it by adding a Maven profile similar to GRPC include-grpc.



---