You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2025/03/18 11:23:22 UTC
[PR] Delete asset relations when dag becomes inactive [airflow]
uranusjr opened a new pull request, #47903:
URL: https://github.com/apache/airflow/pull/47903
This syncs the relations when a dag is deleted in dag files. Makes the "consuming_dags" and "producing_tasks" display correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Delete asset relations when dag becomes inactive [airflow]
Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #47903:
URL: https://github.com/apache/airflow/pull/47903#discussion_r2002141583
##########
airflow/models/asset.py:
##########
@@ -97,6 +98,24 @@ def resolve_ref_to_asset(
return session.scalar(stmt)
+def remove_references_to_deleted_dags(session: Session):
Review Comment:
It would be great to add a test case for this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Delete asset relations when dag becomes inactive [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #47903:
URL: https://github.com/apache/airflow/pull/47903#discussion_r2002776703
##########
airflow/models/asset.py:
##########
@@ -97,6 +98,24 @@ def resolve_ref_to_asset(
return session.scalar(stmt)
+def remove_references_to_deleted_dags(session: Session):
Review Comment:
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Delete asset relations when dag becomes inactive [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr merged PR #47903:
URL: https://github.com/apache/airflow/pull/47903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org