You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/22 06:16:39 UTC

[GitHub] [airflow] pankajastro commented on pull request #25857: Add redshift create cluster snapshot operator

pankajastro commented on PR #25857:
URL: https://github.com/apache/airflow/pull/25857#issuecomment-1221891937

   > Hi @pankajastro. I think this is a good new Operator. But I think a new functionality could be added without the many separate operators. For example, in RDS I added the parameter `db_type` which could be either `'instance'` or `'cluster'`. It gives the possibility to use a single operator for a very similar job. It will be good even if you will add a kind of copy-paste from these PRs:
   > 
   > * [Added Hook for Amazon RDS #20642](https://github.com/apache/airflow/pull/20642)
   > * [Added AWS RDS operators #20907](https://github.com/apache/airflow/pull/20907)
   > * [Added AWS RDS sensors #21231](https://github.com/apache/airflow/pull/21231)
   
   hmm, I liked the Idea but for Redshift, we already have operators like RedshiftPauseClusterOperator, RedshiftResumeClusterOperator etc. I want to add `RedshiftCreateClusterSnapshotOperator` and `RedshiftDeleteClusterSnapshotOperator` I can consolidate these two into one operator `RedshiftClusterSnapshotOperator`, or do you have some thoughts on which would be the potential operator where I can add the this operator? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org