[GitHub] [geode] dschneider-pivotal commented on a diff in pull request #7716: GEODE-10328: close data store stats on cache close

[GitBox <gi...@apache.org>]

dschneider-pivotal commented on code in PR #7716:
URL: https://github.com/apache/geode/pull/7716#discussion_r879712799


##########
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java:
##########
@@ -7767,6 +7768,16 @@ protected void postDestroyRegion(boolean destroyDiskRegion, RegionEventImpl even
         cache.getInternalDistributedSystem().getDistributedMember(), null, op.isClose());
   }
 
+  private void closeDataStoreStats() {
+    PartitionedRegionDataStore localDataStore = dataStore;

Review Comment:
   I think it is needed when reading a field that is not final. I know we currently only ever set it to non-null but I just wanted this code to be future proof against any possible future changes that could modify this non-final field.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org