You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/04/22 01:00:53 UTC

[GitHub] [lucene] rmuir commented on a diff in pull request #828: LUCENE-10528: use Xvfb in test to avoid messing up user's desktop

rmuir commented on code in PR #828:
URL: https://github.com/apache/lucene/pull/828#discussion_r855692000


##########
lucene/luke/src/java/org/apache/lucene/luke/app/desktop/LukeMain.java:
##########
@@ -73,8 +73,8 @@ public static void main(String[] args) throws Exception {
     boolean sanityCheck = Arrays.asList(args).contains("--sanity-check");
 
     if (sanityCheck && GraphicsEnvironment.isHeadless()) {
-      Logger.getGlobal().log(Level.SEVERE, "[Vader] Hello, Luke. Can't do much in headless mode.");
-      Runtime.getRuntime().exit(0);
+      Logger.getGlobal().log(Level.SEVERE, "Hello, Luke. Can't do much in headless mode.");
+      Runtime.getRuntime().exit(1);

Review Comment:
   yeah, see the commit, it is just temporary so that i can ensure test is working in github CI action. i will revert it before pushing anything.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org