You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/10 04:17:11 UTC

[GitHub] [apisix-website] juzhiyuan opened a new pull request #85: fix(doc): copy images to static files

juzhiyuan opened a new pull request #85:
URL: https://github.com/apache/apisix-website/pull/85


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan merged pull request #85: fix(doc): copy images to static files

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #85:
URL: https://github.com/apache/apisix-website/pull/85


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #85: fix(doc): copy images to static files

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #85:
URL: https://github.com/apache/apisix-website/pull/85#discussion_r520284723



##########
File path: .github/workflows/deploy.yml
##########
@@ -20,10 +20,14 @@ jobs:
     # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
     - uses: actions/checkout@v2
 
-    - name: Clone apisix's docs from repo
+    - name: Clone apisix's docs from repo & update image's link
       run: |
         git clone https://github.com/apache/apisix.git
+        cp -r apisix/doc/images ./website/static && rm -rf apisix/doc/images

Review comment:
       We must copy all static images under the `./website/static` folder according to docusaurus




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on pull request #85: fix(doc): copy images to static files

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #85:
URL: https://github.com/apache/apisix-website/pull/85#issuecomment-725060335


   ping @moonming 
   
   https://github.com/apache/apisix-website/pull/84
   https://github.com/apache/apisix-website/pull/85


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #85: fix(doc): copy images to static files

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #85:
URL: https://github.com/apache/apisix-website/pull/85#discussion_r520284542



##########
File path: .github/workflows/deploy.yml
##########
@@ -20,10 +20,14 @@ jobs:
     # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
     - uses: actions/checkout@v2
 
-    - name: Clone apisix's docs from repo
+    - name: Clone apisix's docs from repo & update image's link
       run: |
         git clone https://github.com/apache/apisix.git
+        cp -r apisix/doc/images ./website/static && rm -rf apisix/doc/images
         cp -r apisix/doc ./docs/apisix
+        cd ./docs/apisix
+        find . -type f -name "*.md" -print0 | xargs -0 sed -i '' -e 's/\.\.\/images/https\:\/\/apisix\.apache\.org\/images/g'

Review comment:
       I'm sure there will have easier ways to handle this case, but I have no idea how to do that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org