You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "abhishekindigg (via GitHub)" <gi...@apache.org> on 2024/04/28 02:54:17 UTC
[I] Hiding Force refresh in Dashboard [superset]
abhishekindigg opened a new issue, #28249:
URL: https://github.com/apache/superset/issues/28249
### Bug description
Hello,
I want to disable `Force Refresh` in Dashboard for users. It should only be accessed by the admins.
I created a new role and given only read only permissions, still users are able to do force refresh.
Which permission should I revoke for Gamma users to hide this option ?
### How to reproduce the bug
Go to the dashboard.
In menu, use Force refresh.
### Screenshots/recordings
### Superset version
3.1.2
### Python version
3.11
### Node version
16
### Browser
Chrome
### Additional context
_No response_
### Checklist
- [X] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [X] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [X] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Hiding Force refresh in Dashboard [superset]
Posted by "abhishekindigg (via GitHub)" <gi...@apache.org>.
abhishekindigg commented on issue #28249:
URL: https://github.com/apache/superset/issues/28249#issuecomment-2082006201
Can someone help ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Hiding Force refresh in Dashboard [superset]
Posted by "abhishekindigg (via GitHub)" <gi...@apache.org>.
abhishekindigg commented on issue #28249:
URL: https://github.com/apache/superset/issues/28249#issuecomment-2084494260
@rusackas Frequent refresh causes a lot of query to Athena which also increases our Athena cost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Hiding Force refresh in Dashboard [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on issue #28249:
URL: https://github.com/apache/superset/issues/28249#issuecomment-2089303496
I'm adding a note here as I'm thinking about evolving the security model, and going with a hierarchical action model. I want to make sure that the model we'll come up with will work to support the perm requests across the community.
Here the resource would be `Dashboard` and action would be `read.refresh.force`, where composing a role you could specify you give `read.*` minus `!read.refresh.force`. Clearly will require work to attach perms to actions across the frontend/backend, but seems the model I have in mind (and will publish soon) should support this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Hiding Force refresh in Dashboard [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on issue #28249:
URL: https://github.com/apache/superset/issues/28249#issuecomment-2214941703
No update on my side, was mostly thinking about a recent SIP and how it relates to this, but I wouldn't couple the solutions.
I can point to this https://github.com/apache/superset/pull/27029 as a recent similar PR that may be used for inspiration as to how to implement more granular perms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Hiding Force refresh in Dashboard [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #28249: Hiding Force refresh in Dashboard
URL: https://github.com/apache/superset/issues/28249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Hiding Force refresh in Dashboard [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #28249:
URL: https://github.com/apache/superset/issues/28249#issuecomment-2085644962
Sounds reasonable, but just to play devil's advocate here... are you sure you have a lot of users doing "force refresh" or is the dashboard's cache timeout too short? Also _maybe_ worth noting that people can still run these queries via the chart builder or SQL lab views as frequently as they want.
Another solution would be to put a tool in the middle that queries athena on a schedule (or provides an additional layer of caching, at least), keeping the resulting data in a more cost-effective warehouse/lake/db/etc. which you'd connect Superset to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Hiding Force refresh in Dashboard [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #28249:
URL: https://github.com/apache/superset/issues/28249#issuecomment-2745914913
I'm going to move this to a Discussion, as it's more of a fit for an "Ideas" thread than a bug/issue. Please do chip in on the SIP discussion if you're interested in making this happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Hiding Force refresh in Dashboard [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #28249:
URL: https://github.com/apache/superset/issues/28249#issuecomment-2083462573
I'm not sure if there is such a granular permission for that. I'm curious the use case and why you wouldn't want users to refresh... maybe for embedded purposes?
Maybe @eschutho or @dpgaspar know a permission that can address this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Hiding Force refresh in Dashboard [superset]
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on issue #28249:
URL: https://github.com/apache/superset/issues/28249#issuecomment-2085770666
> I'm not sure if there is such a granular permission for that. I'm curious the use case and why you wouldn't want users to refresh... maybe for embedded purposes?
>
> Maybe @eschutho or @dpgaspar know a permission that can address this.
No specific permission for it. As you said, user's can always hit the endpoint `explore_json` or chart/data`, rate limit could be a solution also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Hiding Force refresh in Dashboard [superset]
Posted by "abhishekindigg (via GitHub)" <gi...@apache.org>.
abhishekindigg commented on issue #28249:
URL: https://github.com/apache/superset/issues/28249#issuecomment-2210791222
@mistercrunch Any update on this? This will save a lot of money.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org