[GitHub] [cloudstack] rhtyd commented on issue #3434: Build css from scss sources in client ui build

[GitBox <gi...@apache.org>]

rhtyd commented on issue #3434: Build css from scss sources in client ui build
URL: https://github.com/apache/cloudstack/pull/3434#issuecomment-507269720
 
 
   Thanks @svenvogel but I still see several large changes and file renames and I'm not sure I understand what is intended to be here. I can make out that it introduces a new gulp/npm dependency during build.
   
   Please have a look at:
   https://github.com/apache/cloudstack/pull/3444#issuecomment-507180721
   
   Copied from above:
   ```
    there have been several css/UI related PRs proposed recently, can you start a discussion thread on dev@ to explain what are the goals and refactorings you're trying to do. I'm personally not sure where the UI changes are heading and would like to learn more.
   
   Typically any framework/component related changes and refactorings may have a design document to capture this that is shared with the dev community for review and discussion. Any proposals and discussions are welcome on dev@. Thanks.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services