You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-dev@hadoop.apache.org by "Henry Robinson (JIRA)" <ji...@apache.org> on 2013/05/15 00:25:16 UTC

[jira] [Created] (HDFS-4824) FileInputStreamCache.close leaves dangling reference to FileInputStreamCache.cacheCleaner

Henry Robinson created HDFS-4824:
------------------------------------

             Summary: FileInputStreamCache.close leaves dangling reference to FileInputStreamCache.cacheCleaner
                 Key: HDFS-4824
                 URL: https://issues.apache.org/jira/browse/HDFS-4824
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: hdfs-client
    Affects Versions: 2.0.4-alpha
            Reporter: Henry Robinson
            Assignee: Colin Patrick McCabe


{{FileInputStreamCache}} leaves around a reference to its {{cacheCleaner}} after {{close()}}.

The {{cacheCleaner}} is created like this:

{code}
if (cacheCleaner == null) {
          cacheCleaner = new CacheCleaner();
          executor.scheduleAtFixedRate(cacheCleaner, expiryTimeMs, expiryTimeMs,
              TimeUnit.MILLISECONDS);
        }
{code}

and supposedly removed like this:

{code}
if (cacheCleaner != null) {
  executor.remove(cacheCleaner);
}
{code}

However, {{ScheduledThreadPoolExecutor.remove}} returns a success boolean which should be checked. And I _think_ from a quick read of that class that the return value of {{scheduleAtFixedRate}} should be used as the argument to {{remove}}. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: [jira] [Created] (HDFS-4824) FileInputStreamCache.close leaves dangling reference to FileInputStreamCache.cacheCleaner

Posted by Colin McCabe <cm...@alumni.cmu.edu>.
Hi Shouvanik,

Why not try asking the Talend community?

Also, this question belongs on the user list.

thanks,
Colin


On Wed, May 15, 2013 at 4:20 AM, Shouvanik Haldar <
shouvanik.haldar@gmail.com> wrote:

> Hi,
>
> I am facing a problem.
>
> I am using Talend for scheduling and running a job. But, I am getting a
> error. can anybody please help.
>
> [2013-05-15 16:30:59]Deploying job to Hadoop...
> [2013-05-15 16:31:08]Deployment failed!
> [2013-05-15 16:31:08]Can not access Hadoop File System with user root!
> [2013-05-15 16:31:08]Server IPC version 7 cannot communicate with client
> version 4
>
> Regards,
> Shouvanik
>
>
> On Wed, May 15, 2013 at 3:55 AM, Henry Robinson (JIRA) <jira@apache.org
> >wrote:
>
> > Henry Robinson created HDFS-4824:
> > ------------------------------------
> >
> >              Summary: FileInputStreamCache.close leaves dangling
> reference
> > to FileInputStreamCache.cacheCleaner
> >                  Key: HDFS-4824
> >                  URL: https://issues.apache.org/jira/browse/HDFS-4824
> >              Project: Hadoop HDFS
> >           Issue Type: Bug
> >           Components: hdfs-client
> >     Affects Versions: 2.0.4-alpha
> >             Reporter: Henry Robinson
> >             Assignee: Colin Patrick McCabe
> >
> >
> > {{FileInputStreamCache}} leaves around a reference to its
> {{cacheCleaner}}
> > after {{close()}}.
> >
> > The {{cacheCleaner}} is created like this:
> >
> > {code}
> > if (cacheCleaner == null) {
> >           cacheCleaner = new CacheCleaner();
> >           executor.scheduleAtFixedRate(cacheCleaner, expiryTimeMs,
> > expiryTimeMs,
> >               TimeUnit.MILLISECONDS);
> >         }
> > {code}
> >
> > and supposedly removed like this:
> >
> > {code}
> > if (cacheCleaner != null) {
> >   executor.remove(cacheCleaner);
> > }
> > {code}
> >
> > However, {{ScheduledThreadPoolExecutor.remove}} returns a success boolean
> > which should be checked. And I _think_ from a quick read of that class
> that
> > the return value of {{scheduleAtFixedRate}} should be used as the
> argument
> > to {{remove}}.
> >
> > --
> > This message is automatically generated by JIRA.
> > If you think it was sent incorrectly, please contact your JIRA
> > administrators
> > For more information on JIRA, see:
> http://www.atlassian.com/software/jira
> >
>
>
>
> --
> Thanks,
> *Shouvanik*
>

Re: [jira] [Created] (HDFS-4824) FileInputStreamCache.close leaves dangling reference to FileInputStreamCache.cacheCleaner

Posted by Shouvanik Haldar <sh...@gmail.com>.
Hi,

I am facing a problem.

I am using Talend for scheduling and running a job. But, I am getting a
error. can anybody please help.

[2013-05-15 16:30:59]Deploying job to Hadoop...
[2013-05-15 16:31:08]Deployment failed!
[2013-05-15 16:31:08]Can not access Hadoop File System with user root!
[2013-05-15 16:31:08]Server IPC version 7 cannot communicate with client
version 4

Regards,
Shouvanik


On Wed, May 15, 2013 at 3:55 AM, Henry Robinson (JIRA) <ji...@apache.org>wrote:

> Henry Robinson created HDFS-4824:
> ------------------------------------
>
>              Summary: FileInputStreamCache.close leaves dangling reference
> to FileInputStreamCache.cacheCleaner
>                  Key: HDFS-4824
>                  URL: https://issues.apache.org/jira/browse/HDFS-4824
>              Project: Hadoop HDFS
>           Issue Type: Bug
>           Components: hdfs-client
>     Affects Versions: 2.0.4-alpha
>             Reporter: Henry Robinson
>             Assignee: Colin Patrick McCabe
>
>
> {{FileInputStreamCache}} leaves around a reference to its {{cacheCleaner}}
> after {{close()}}.
>
> The {{cacheCleaner}} is created like this:
>
> {code}
> if (cacheCleaner == null) {
>           cacheCleaner = new CacheCleaner();
>           executor.scheduleAtFixedRate(cacheCleaner, expiryTimeMs,
> expiryTimeMs,
>               TimeUnit.MILLISECONDS);
>         }
> {code}
>
> and supposedly removed like this:
>
> {code}
> if (cacheCleaner != null) {
>   executor.remove(cacheCleaner);
> }
> {code}
>
> However, {{ScheduledThreadPoolExecutor.remove}} returns a success boolean
> which should be checked. And I _think_ from a quick read of that class that
> the return value of {{scheduleAtFixedRate}} should be used as the argument
> to {{remove}}.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>



-- 
Thanks,
*Shouvanik*