You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "simple-xair (via GitHub)" <gi...@apache.org> on 2025/11/30 12:16:41 UTC

[PR] test: add unit test for pkg/rm/config [incubator-seata-go]

simple-xair opened a new pull request, #1006:
URL: https://github.com/apache/incubator-seata-go/pull/1006

   Which issue(s) this PR fixes:
   
   Fixes https://github.com/apache/incubator-seata-go/issues/1002


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] test: add unit test for pkg/rm/config [incubator-seata-go]

Posted by "Code-Fight (via GitHub)" <gi...@apache.org>.
Code-Fight merged PR #1006:
URL: https://github.com/apache/incubator-seata-go/pull/1006


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] test: add unit test for pkg/rm/config [incubator-seata-go]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1006:
URL: https://github.com/apache/incubator-seata-go/pull/1006#issuecomment-3601561212

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1006?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 61.77%. Comparing base ([`6437e52`](https://app.codecov.io/gh/apache/incubator-seata-go/commit/6437e520047f0cfebdc408f62135c0a3d70b9310?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`62f2d3c`](https://app.codecov.io/gh/apache/incubator-seata-go/commit/62f2d3cfd0d341448ef9495e2424b4b382f528f1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1006      +/-   ##
   ==========================================
   + Coverage   61.64%   61.77%   +0.12%     
   ==========================================
     Files         213      213              
     Lines       13056    13056              
   ==========================================
   + Hits         8049     8065      +16     
   + Misses       4483     4467      -16     
     Partials      524      524              
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-seata-go/pull/1006?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] test: add unit test for pkg/rm/config [incubator-seata-go]

Posted by "LucienShen-Liu (via GitHub)" <gi...@apache.org>.
LucienShen-Liu commented on PR #1006:
URL: https://github.com/apache/incubator-seata-go/pull/1006#issuecomment-3609951572

   Let's see if the coverage can be improved further; the improvement so far seems minimal.
   <img width="446" height="288" alt="image" src="https://github.com/user-attachments/assets/7a5dbf37-7d03-47b6-844a-b9d19d5e1e5a" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] test: add unit test for pkg/rm/config [incubator-seata-go]

Posted by "0x-infinity (via GitHub)" <gi...@apache.org>.
0x-infinity commented on PR #1006:
URL: https://github.com/apache/incubator-seata-go/pull/1006#issuecomment-3601561963

   Please resolve the CI issue, re-add the license headers using `goimports.sh`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org