You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by galen-pivotal <gi...@git.apache.org> on 2017/03/31 19:11:46 UTC

[GitHub] geode pull request #437: GEODE-2653: Fix testRemoveMember and remove FlakyTe...

GitHub user galen-pivotal opened a pull request:

    https://github.com/apache/geode/pull/437

    GEODE-2653: Fix testRemoveMember and remove FlakyTest.

    And do some cleanup while I'm here:
     * Change Mockito's `any` to `isA`.
     * Replace some `Thread.sleep()` calls with Awaitility calls.
     * Remove our `MethodExecuted` class -- this can be done with Mockito's`verify()`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/galen-pivotal/geode feature/GEODE-2653

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/437.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #437
    
----
commit 6ffdee107a000d781c37f9b924b5e56197fbec06
Author: Galen OSullivan <go...@pivotal.io>
Date:   2017-03-31T18:44:54Z

    GEODE-2653: Fix testRemoveMember and remove FlakyTest.
    
    Test removed self instead of the other member, and used the `any`
    matcher instead of `isA`.

commit f0dfd1fc2b468b0482a08726df3b587da05d7102
Author: Galen OSullivan <go...@pivotal.io>
Date:   2017-03-31T19:07:23Z

    Cleanup GMSJoinLeaveJUnitTest.
    
    * Change Mockito's `any` to `isA`.
    * Replace some `Thread.sleep()` calls with Awaitility calls.
    * Remove our `MethodExecuted` class -- this can be done with Mockito's
      `verify()`.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #437: GEODE-2653: Fix testRemoveMember and remove FlakyTest.

Posted by galen-pivotal <gi...@git.apache.org>.

Github user galen-pivotal commented on the issue:

    https://github.com/apache/geode/pull/437
  
    @kohlmu-pivotal 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #437: GEODE-2653: Fix testRemoveMember and remove FlakyTe...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/geode/pull/437


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #437: GEODE-2653: Fix testRemoveMember and remove FlakyTest.

Posted by galen-pivotal <gi...@git.apache.org>.

Github user galen-pivotal commented on the issue:

    https://github.com/apache/geode/pull/437
  
    @bschuchardt this is https://reviews.apache.org/r/58155/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---