You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/20 11:06:35 UTC
[GitHub] [flink] rovboyko opened a new pull request, #19778: [FLINK-27418][table-planner] fix topN retraction for previously delet…
rovboyko opened a new pull request, #19778:
URL: https://github.com/apache/flink/pull/19778
…ed record
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Fixing the bug inside RetractableTopNFunction. The bug occurs when the record initially inserted inside topN, then it is dropped out from topN by another record and then deleted by retraction message from upstream operator. In such case the record remains inside the dataState with RowKind.Delete prefix.
## Brief change log
- added input row serializer to RetractableTopNFunction
- added record copying while deleting it from topN
- added specific test to RetractableTopNFunctionTest
## Verifying this change
Extended unit tests for RetractableTopNFunction
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #19778: [FLINK-27418][table-planner] fix topN retraction for previously delet…
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #19778:
URL: https://github.com/apache/flink/pull/19778#issuecomment-1137117750
@lsyldliu Can you review this? Or should @wuchong do this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19778: [FLINK-27418][table-planner] fix topN retraction for previously delet…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19778:
URL: https://github.com/apache/flink/pull/19778#issuecomment-1132775661
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f0affacf9db5723adfa6896e7d1da312ad3a971e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f0affacf9db5723adfa6896e7d1da312ad3a971e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0affacf9db5723adfa6896e7d1da312ad3a971e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lincoln-lil commented on pull request #19778: [FLINK-27418][table-planner] fix topN retraction for previously delet…
Posted by GitBox <gi...@apache.org>.
lincoln-lil commented on PR #19778:
URL: https://github.com/apache/flink/pull/19778#issuecomment-1148345509
@rovboyko Thanks for fixing it! The change looks good to me and I've checked the other two places which also invoke the collectDelete without rownumber(UpdatableTopNFunction#L538 and AppendOnlyTopNFunction#L242), no problem there.
Although this fix adds a bit of serialization overhead, correctness is paramount, and I can't think of a better way to do copy on demand.
cc @wuchong if you have some time to double check, it would be much appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #19778: [FLINK-27418][table-planner] fix topN retraction for previously delet…
Posted by GitBox <gi...@apache.org>.
wuchong merged PR #19778:
URL: https://github.com/apache/flink/pull/19778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org