You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ambari.apache.org by yu...@apache.org on 2014/04/08 02:04:56 UTC

[1/2] git commit: AMBARI-5381. Installer: 'Undo' button for repo BaseURL is unnecessarily present. (xiwang via yusaku)

Repository: ambari
Updated Branches:
  refs/heads/trunk 7d98fc56b -> b1eabddf9


AMBARI-5381. Installer: 'Undo' button for repo BaseURL is unnecessarily present. (xiwang via yusaku)


Project: http://git-wip-us.apache.org/repos/asf/ambari/repo
Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/b1eabddf
Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/b1eabddf
Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/b1eabddf

Branch: refs/heads/trunk
Commit: b1eabddf9415ce1b11ee2e3e7f60472daaca9a9c
Parents: fa47bc2
Author: Yusaku Sako <yu...@hortonworks.com>
Authored: Mon Apr 7 16:57:05 2014 -0700
Committer: Yusaku Sako <yu...@hortonworks.com>
Committed: Mon Apr 7 16:57:18 2014 -0700

----------------------------------------------------------------------
 ambari-web/app/views/wizard/step1_view.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ambari/blob/b1eabddf/ambari-web/app/views/wizard/step1_view.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/views/wizard/step1_view.js b/ambari-web/app/views/wizard/step1_view.js
index 17211fb..5734a4d 100644
--- a/ambari-web/app/views/wizard/step1_view.js
+++ b/ambari-web/app/views/wizard/step1_view.js
@@ -222,7 +222,7 @@ App.WizardStep1View = Em.View.extend({
     group.set('empty-error', !os.baseUrl);
     group.set('invalid-error', os.validation == 'icon-exclamation-sign');
     group.set('validation', os.validation);
-    group.set('undo', os.baseUrl != os.defaultBaseUrl);
+    group.set('undo', os.baseUrl != os.latestBaseUrl);
     group.set('clearAll', os.baseUrl);
     group.set('errorTitle', os.errorTitle);
     group.set('errorContent', os.errorContent);
@@ -247,7 +247,7 @@ App.WizardStep1View = Em.View.extend({
           os.selected = false;
           targetGroup.set('baseUrl', os.latestBaseUrl);
           targetGroup.set('latestBaseUrl', os.latestBaseUrl);
-          targetGroup.set('undo', targetGroup.get('baseUrl') != targetGroup.get('defaultBaseUrl'));
+          targetGroup.set('undo', targetGroup.get('baseUrl') != targetGroup.get('latestBaseUrl'));
           targetGroup.set('invalid-error', false);
           targetGroup.set('validation', null);
           targetGroup.set('clearAll', false);
@@ -327,7 +327,7 @@ App.WizardStep1View = Em.View.extend({
         if (os.baseUrl != targetGroup.get('baseUrl')) {
           os.baseUrl = targetGroup.get('baseUrl');
           os.validation = null;
-          targetGroup.set('undo', targetGroup.get('baseUrl') != targetGroup.get('defaultBaseUrl'));
+          targetGroup.set('undo', targetGroup.get('baseUrl') != targetGroup.get('latestBaseUrl'));
           targetGroup.set('invalid-error', false);
           targetGroup.set('validation', null);
           targetGroup.set('clearAll', os.baseUrl);


[2/2] git commit: AMBARI-5386. Deploy stuck during generating tasks on Review page (not always reproduced). (yusaku)

Posted by yu...@apache.org.
AMBARI-5386. Deploy stuck during generating tasks on Review page (not always reproduced). (yusaku)


Project: http://git-wip-us.apache.org/repos/asf/ambari/repo
Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/fa47bc20
Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/fa47bc20
Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/fa47bc20

Branch: refs/heads/trunk
Commit: fa47bc20c9fe698d178d52434a22f8737753fb60
Parents: 7d98fc5
Author: Yusaku Sako <yu...@hortonworks.com>
Authored: Mon Apr 7 16:15:25 2014 -0700
Committer: Yusaku Sako <yu...@hortonworks.com>
Committed: Mon Apr 7 16:57:18 2014 -0700

----------------------------------------------------------------------
 ambari-web/app/controllers/wizard/step8_controller.js | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ambari/blob/fa47bc20/ambari-web/app/controllers/wizard/step8_controller.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/controllers/wizard/step8_controller.js b/ambari-web/app/controllers/wizard/step8_controller.js
index bb3f5b8..9958dda 100644
--- a/ambari-web/app/controllers/wizard/step8_controller.js
+++ b/ambari-web/app/controllers/wizard/step8_controller.js
@@ -874,6 +874,10 @@ App.WizardStep8Controller = Em.Controller.extend({
 
   /**
    * Updates local repositories for the Ambari server.
+   * Base URL validation is disabled, since the checks had already run in the Select Stacks page
+   * already (unless the user specifically asked to skip).
+   * TODO: This function should be deleted once we modify App.InstallerController to make
+   * sure that base URLs are saved even when "Skip validation" is checked.
    */
   setLocalRepositories: function () {
     if (this.get('content.controllerName') !== 'installerController' || !App.supports.localRepositories) return;
@@ -888,7 +892,8 @@ App.WizardStep8Controller = Em.Controller.extend({
           url: App.apiPrefix + App.get('stack2VersionURL') + "/operatingSystems/" + os.osType + "/repositories/" + stack.name,
           data: JSON.stringify({
             "Repositories": {
-              "base_url": os.baseUrl
+              "base_url": os.baseUrl,
+              "verify_base_url": false
             }
           })
         });