[GitHub] [airflow] bbovenzi commented on a change in pull request #19792: Dynamically enable "Test Connection" button by connection type

[GitBox <gi...@apache.org>]

bbovenzi commented on a change in pull request #19792:
URL: https://github.com/apache/airflow/pull/19792#discussion_r755564419



##########
File path: airflow/www/static/js/connection_form.js
##########
@@ -129,8 +154,9 @@ $(document).ready(() => {
   const testConnBtn = $('<button id="test-connection" type="button" class="btn btn-sm btn-primary" '
     + 'style="margin-left: 3px; pointer-events: all">Test\n <i class="fa fa-rocket"></i></button>');
 
+  // Disable the Test Connection button if Airflow REST APIs are not enabled.
   if (!restApiEnabled) {
-    $(testConnBtn).addClass('disabled')
+    $(testConnBtn).prop('disabled', true)

Review comment:
       We can delete line 142 and just do this:
   
   ```suggestion
       $("#testable_connection_types").prop('disabled', true)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org