You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/24 09:54:37 UTC

[GitHub] [pulsar] linlinnn opened a new pull request #11071: clear redundant code

linlinnn opened a new pull request #11071:
URL: https://github.com/apache/pulsar/pull/11071


   ### Modifications
   clear redundant code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] linlinnn closed pull request #11071: clear redundant code

Posted by GitBox <gi...@apache.org>.
linlinnn closed pull request #11071:
URL: https://github.com/apache/pulsar/pull/11071


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] linlinnn commented on pull request #11071: clear redundant code

Posted by GitBox <gi...@apache.org>.
linlinnn commented on pull request #11071:
URL: https://github.com/apache/pulsar/pull/11071#issuecomment-867541611


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on a change in pull request #11071: clear redundant code

Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #11071:
URL: https://github.com/apache/pulsar/pull/11071#discussion_r658986263



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1048,12 +1048,12 @@ public PulsarClient getReplicationClient(String cluster) {
                     clientBuilder.serviceUrl(
                             isNotBlank(data.getBrokerServiceUrl()) ? data.getBrokerServiceUrl() : data.getServiceUrl());
                 }
-                if (data.getProxyProtocol() != null && StringUtils.isNotBlank(data.getProxyServiceUrl())) {

Review comment:
       they are two different settings. One is `getProxyProtocol` and the other one is `getProxyServiceUrl`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] linlinnn commented on a change in pull request #11071: clear redundant code

Posted by GitBox <gi...@apache.org>.
linlinnn commented on a change in pull request #11071:
URL: https://github.com/apache/pulsar/pull/11071#discussion_r658411063



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1048,12 +1048,12 @@ public PulsarClient getReplicationClient(String cluster) {
                     clientBuilder.serviceUrl(
                             isNotBlank(data.getBrokerServiceUrl()) ? data.getBrokerServiceUrl() : data.getServiceUrl());
                 }
-                if (data.getProxyProtocol() != null && StringUtils.isNotBlank(data.getProxyServiceUrl())) {

Review comment:
       StringUtils.isNotBlank contains this check, if `data.getProxyProtocol()` is null, then return false




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #11071: clear redundant code

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #11071:
URL: https://github.com/apache/pulsar/pull/11071


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] linlinnn commented on a change in pull request #11071: clear redundant code

Posted by GitBox <gi...@apache.org>.
linlinnn commented on a change in pull request #11071:
URL: https://github.com/apache/pulsar/pull/11071#discussion_r659110286



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1048,12 +1048,12 @@ public PulsarClient getReplicationClient(String cluster) {
                     clientBuilder.serviceUrl(
                             isNotBlank(data.getBrokerServiceUrl()) ? data.getBrokerServiceUrl() : data.getServiceUrl());
                 }
-                if (data.getProxyProtocol() != null && StringUtils.isNotBlank(data.getProxyServiceUrl())) {

Review comment:
       oh, sorry, I will fix it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on a change in pull request #11071: clear redundant code

Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #11071:
URL: https://github.com/apache/pulsar/pull/11071#discussion_r658401869



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1048,12 +1048,12 @@ public PulsarClient getReplicationClient(String cluster) {
                     clientBuilder.serviceUrl(
                             isNotBlank(data.getBrokerServiceUrl()) ? data.getBrokerServiceUrl() : data.getServiceUrl());
                 }
-                if (data.getProxyProtocol() != null && StringUtils.isNotBlank(data.getProxyServiceUrl())) {

Review comment:
       I think we need this `data.getProxyProtocol() != null` check, no?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org