[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6721: WIP: Pinot SPI refactor (no functionality change)

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #6721:
URL: https://github.com/apache/incubator-pinot/pull/6721#discussion_r604475827



##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/pruner/PartitionZKMetadataPruner.java
##########
@@ -26,7 +26,7 @@
 import org.apache.pinot.common.metadata.segment.SegmentZKMetadata;
 import org.apache.pinot.common.request.FilterOperator;
 import org.apache.pinot.common.utils.request.FilterQueryTree;
-import org.apache.pinot.core.data.partition.PartitionFunction;
+import org.apache.pinot.query.spi.PartitionFunction;

Review comment:
       @mayankshriv All these imports are **related** to this refactor as the imports order are correct before this refactor, but because of the package name change, they become incorrect.
   @mqliang Great suggestion on forcing the format using maven plugin. Can you please open an issue for that (a PR is even better :-P)?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org