You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/11/16 01:22:19 UTC

[GitHub] yzhliu closed pull request #13295: [MXNET-1217] Clean up the way of testing

yzhliu closed pull request #13295: [MXNET-1217] Clean up the way of testing
URL: https://github.com/apache/incubator-mxnet/pull/13295
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/Makefile b/Makefile
index 638a0864dc5..b1231173664 100644
--- a/Makefile
+++ b/Makefile
@@ -605,7 +605,7 @@ scalaclean:
 
 scalapkg:
 	(cd $(ROOTDIR)/scala-package; \
-		mvn package -P$(SCALA_PKG_PROFILE),$(SCALA_VERSION_PROFILE),integrationtest -Dcxx="$(CXX)" \
+		mvn package -P$(SCALA_PKG_PROFILE),$(SCALA_VERSION_PROFILE) -Dcxx="$(CXX)" \
 		    -Dbuild.platform="$(SCALA_PKG_PROFILE)" \
 			-Dcflags="$(CFLAGS)" -Dldflags="$(LDFLAGS)" \
 			-Dcurrent_libdir="$(ROOTDIR)/lib" \
diff --git a/scala-package/core/pom.xml b/scala-package/core/pom.xml
index d5396dab1e6..1445c0bf270 100644
--- a/scala-package/core/pom.xml
+++ b/scala-package/core/pom.xml
@@ -10,6 +10,10 @@
     <relativePath>../pom.xml</relativePath>
   </parent>
 
+  <properties>
+    <skipTests>true</skipTests>
+  </properties>
+
   <artifactId>mxnet-core_2.11</artifactId>
   <name>MXNet Scala Package - Core</name>
 
@@ -20,12 +24,6 @@
         <skipTests>false</skipTests>
       </properties>
     </profile>
-    <profile>
-      <id>integrationtest</id>
-      <properties>
-        <skipTests>true</skipTests>
-      </properties>
-    </profile>
     <profile>
       <id>osx-x86_64-cpu</id>
       <properties>
diff --git a/scala-package/examples/pom.xml b/scala-package/examples/pom.xml
index 436f2992768..72a40dc01f0 100644
--- a/scala-package/examples/pom.xml
+++ b/scala-package/examples/pom.xml
@@ -13,13 +13,11 @@
   <artifactId>mxnet-examples_2.11</artifactId>
   <name>MXNet Scala Package - Examples</name>
 
+  <properties>
+    <skipTests>true</skipTests>
+  </properties>
+
   <profiles>
-    <profile>
-      <id>unittest</id>
-      <properties>
-        <skipTests>true</skipTests>
-      </properties>
-    </profile>
     <profile>
       <id>integrationtest</id>
       <properties>
diff --git a/scala-package/infer/pom.xml b/scala-package/infer/pom.xml
index e5010016932..91a1e1b30d2 100644
--- a/scala-package/infer/pom.xml
+++ b/scala-package/infer/pom.xml
@@ -13,6 +13,10 @@
     <artifactId>mxnet-infer_2.11</artifactId>
     <name>MXNet Scala Package - Inference</name>
 
+    <properties>
+        <skipTests>true</skipTests>
+    </properties>
+
     <profiles>
         <profile>
             <id>unittest</id>
@@ -20,12 +24,6 @@
                 <skipTests>false</skipTests>
             </properties>
         </profile>
-        <profile>
-            <id>integrationtest</id>
-            <properties>
-                <skipTests>true</skipTests>
-            </properties>
-        </profile>
         <profile>
             <id>osx-x86_64-cpu</id>
             <properties>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services