You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Wang Xixu (Code Review)" <ge...@cloudera.org> on 2023/02/02 01:53:42 UTC

[kudu-CR] [KUDU-3438] TabletCopyClientAbortTest might crash

Hello Tidy Bot, Alexey Serbin, Yingchun Lai, Yifan Zhang, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19451

to look at the new patch set (#4).

Change subject: [KUDU-3438] TabletCopyClientAbortTest might crash
......................................................................

[KUDU-3438] TabletCopyClientAbortTest might crash

TabletCopyClientTest::SetUp() of TabletCopyClientAbortTest may fail,
for example, because of the full disk. TabletCopyClient will be not
initialized. Therefore using TabletCopyClient in StartCopy() will
cause a crash.

It is better to Add NO_FATALS() for TabletCopyClientTest::SetUp()
to avoid nullptr TabletCopyClient.

Change-Id: Id1eeea183bf9fc0b566e6a70f2f7520f34b2ae3c
---
M src/kudu/tserver/tablet_copy_client-test.cc
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/19451/4
-- 
To view, visit http://gerrit.cloudera.org:8080/19451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id1eeea183bf9fc0b566e6a70f2f7520f34b2ae3c
Gerrit-Change-Number: 19451
Gerrit-PatchSet: 4
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>