You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by jaredjstewart <gi...@git.apache.org> on 2017/01/12 21:17:58 UTC

[GitHub] geode pull request #335: Pulse fixes

GitHub user jaredjstewart opened a pull request:

    https://github.com/apache/geode/pull/335

    Pulse fixes

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaredjstewart/geode pulseFixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/335.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #335
    
----
commit 3a0cbdce7e65d0b98411e07b3c2bd2706ec47b32
Author: Jared Stewart <js...@pivotal.io>
Date:   2017-01-05T22:44:58Z

    GEODE-1114: RemoveGemfireXD references from Pulse

commit 724bb4932b3f5bdf65fd12c141909966e7f62796
Author: Jared Stewart <js...@pivotal.io>
Date:   2017-01-10T18:53:49Z

    GEODE-2194: Fix Pulse webapp context
    
    * Pulse no longer has redundant URLs like http://localhost/pulse/pulse/pulseVersion

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #335: Pulse fixes

Posted by jaredjstewart <gi...@git.apache.org>.
Github user jaredjstewart commented on a diff in the pull request:

    https://github.com/apache/geode/pull/335#discussion_r95897532
  
    --- Diff: geode-pulse/src/main/webapp/WEB-INF/web.xml ---
    @@ -32,7 +32,7 @@
       </servlet>
       <servlet-mapping>
         <servlet-name>mvc-dispatcher</servlet-name>
    -    <url-pattern>/pulse/*</url-pattern>
    --- End diff --
    
    It still works because of the "/pulse" webAppContext string passed into `JettyHelper.addWebApplication()`. Jetty only passes requests for URLs matching this webAppContext into the Pulse webapp, so if a URL doesn't match /pulse it never makes it into this servlet mapping.  However, maybe we still ought to leave it as `<url-pattern>/pulse/*</url-pattern>` for clarity of intent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #335: Pulse fixes

Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on a diff in the pull request:

    https://github.com/apache/geode/pull/335#discussion_r95898738
  
    --- Diff: geode-pulse/src/main/webapp/WEB-INF/web.xml ---
    @@ -32,7 +32,7 @@
       </servlet>
       <servlet-mapping>
         <servlet-name>mvc-dispatcher</servlet-name>
    -    <url-pattern>/pulse/*</url-pattern>
    --- End diff --
    
    i see. if changing it back to /pulse/* makes no difference, then add it back for clarify.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #335: Pulse fixes

Posted by jaredjstewart <gi...@git.apache.org>.
Github user jaredjstewart commented on the issue:

    https://github.com/apache/geode/pull/335
  
    Precheckin passed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #335: Pulse fixes

Posted by jaredjstewart <gi...@git.apache.org>.
Github user jaredjstewart commented on a diff in the pull request:

    https://github.com/apache/geode/pull/335#discussion_r95899936
  
    --- Diff: geode-pulse/src/main/webapp/WEB-INF/web.xml ---
    @@ -32,7 +32,7 @@
       </servlet>
       <servlet-mapping>
         <servlet-name>mvc-dispatcher</servlet-name>
    -    <url-pattern>/pulse/*</url-pattern>
    --- End diff --
    
    I've updated the commit to revert this line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #335: Pulse fixes

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/geode/pull/335


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #335: Pulse fixes

Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on a diff in the pull request:

    https://github.com/apache/geode/pull/335#discussion_r95892864
  
    --- Diff: geode-pulse/src/main/webapp/WEB-INF/web.xml ---
    @@ -32,7 +32,7 @@
       </servlet>
       <servlet-mapping>
         <servlet-name>mvc-dispatcher</servlet-name>
    -    <url-pattern>/pulse/*</url-pattern>
    --- End diff --
    
    This seems dangerous. Is this ok because we are already deploying the war under /pulse? Have you tested starting pulse and connect to gfsh using http?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---