You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/07/14 03:43:58 UTC
Review Request: Fixes a bug in the allocator that didn't properly handle
master failover when slaves connect before frameworks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5947/
-----------------------------------------------------------
Review request for mesos, Thomas Marshall and Vinod Kone.
Description
-------
See summary.
Diffs
-----
src/master/allocator.hpp 38736cb
src/master/dominant_share_allocator.hpp 6587f33
src/master/dominant_share_allocator.cpp 1ea29c7
src/master/master.hpp 6cb4810
src/master/master.cpp d6d2905
src/tests/allocator_tests.cpp 610826b
src/tests/resource_offers_tests.cpp d06cae2
src/tests/utils.hpp 780ac2a
Diff: https://reviews.apache.org/r/5947/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Fixes a bug in the allocator that didn't properly handle
master failover when slaves connect before frameworks.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On July 16, 2012, 8:53 p.m., Vinod Kone wrote:
> > Ship It!
Thank you sir, submitted.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5947/#review9197
-----------------------------------------------------------
On July 16, 2012, 7:32 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5947/
> -----------------------------------------------------------
>
> (Updated July 16, 2012, 7:32 p.m.)
>
>
> Review request for mesos, Thomas Marshall and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator.hpp 38736cb
> src/master/dominant_share_allocator.hpp 6587f33
> src/master/dominant_share_allocator.cpp 1ea29c7
> src/master/master.hpp 6cb4810
> src/master/master.cpp d6d2905
> src/tests/allocator_tests.cpp 610826b
> src/tests/resource_offers_tests.cpp d06cae2
> src/tests/utils.hpp 780ac2a
>
> Diff: https://reviews.apache.org/r/5947/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Fixes a bug in the allocator that didn't properly handle
master failover when slaves connect before frameworks.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5947/#review9197
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On July 16, 2012, 7:32 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5947/
> -----------------------------------------------------------
>
> (Updated July 16, 2012, 7:32 p.m.)
>
>
> Review request for mesos, Thomas Marshall and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator.hpp 38736cb
> src/master/dominant_share_allocator.hpp 6587f33
> src/master/dominant_share_allocator.cpp 1ea29c7
> src/master/master.hpp 6cb4810
> src/master/master.cpp d6d2905
> src/tests/allocator_tests.cpp 610826b
> src/tests/resource_offers_tests.cpp d06cae2
> src/tests/utils.hpp 780ac2a
>
> Diff: https://reviews.apache.org/r/5947/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Fixes a bug in the allocator that didn't properly handle
master failover when slaves connect before frameworks.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5947/
-----------------------------------------------------------
(Updated July 16, 2012, 7:32 p.m.)
Review request for mesos, Thomas Marshall and Vinod Kone.
Changes
-------
Tweaks.
Description
-------
See summary.
Diffs (updated)
-----
src/master/allocator.hpp 38736cb
src/master/dominant_share_allocator.hpp 6587f33
src/master/dominant_share_allocator.cpp 1ea29c7
src/master/master.hpp 6cb4810
src/master/master.cpp d6d2905
src/tests/allocator_tests.cpp 610826b
src/tests/resource_offers_tests.cpp d06cae2
src/tests/utils.hpp 780ac2a
Diff: https://reviews.apache.org/r/5947/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Fixes a bug in the allocator that didn't properly handle
master failover when slaves connect before frameworks.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5947/
-----------------------------------------------------------
(Updated July 16, 2012, 7:24 p.m.)
Review request for mesos, Thomas Marshall and Vinod Kone.
Changes
-------
Updated from review comments.
Description
-------
See summary.
Diffs (updated)
-----
src/master/allocator.hpp 38736cb
src/master/dominant_share_allocator.hpp 6587f33
src/master/dominant_share_allocator.cpp 1ea29c7
src/master/master.hpp 6cb4810
src/master/master.cpp d6d2905
src/tests/allocator_tests.cpp 610826b
src/tests/resource_offers_tests.cpp d06cae2
src/tests/utils.hpp 780ac2a
Diff: https://reviews.apache.org/r/5947/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Fixes a bug in the allocator that didn't properly handle
master failover when slaves connect before frameworks.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On July 16, 2012, 5:39 p.m., Vinod Kone wrote:
> > src/master/dominant_share_allocator.cpp, line 133
> > <https://reviews.apache.org/r/5947/diff/2/?file=122548#file122548line133>
> >
> > what does used signify here? I dont think I follow the logic.
Added a comment in the code that uses 'used'.
> On July 16, 2012, 5:39 p.m., Vinod Kone wrote:
> > src/master/dominant_share_allocator.cpp, line 138
> > <https://reviews.apache.org/r/5947/diff/2/?file=122548#file122548line138>
> >
> > can u move this up, since its being used for both if and else. makes it clear that updating frameworks is going to happen irrespective of if..else.
Yup, refactored and added a comment.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5947/#review9178
-----------------------------------------------------------
On July 16, 2012, 7:24 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5947/
> -----------------------------------------------------------
>
> (Updated July 16, 2012, 7:24 p.m.)
>
>
> Review request for mesos, Thomas Marshall and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator.hpp 38736cb
> src/master/dominant_share_allocator.hpp 6587f33
> src/master/dominant_share_allocator.cpp 1ea29c7
> src/master/master.hpp 6cb4810
> src/master/master.cpp d6d2905
> src/tests/allocator_tests.cpp 610826b
> src/tests/resource_offers_tests.cpp d06cae2
> src/tests/utils.hpp 780ac2a
>
> Diff: https://reviews.apache.org/r/5947/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Fixes a bug in the allocator that didn't properly handle
master failover when slaves connect before frameworks.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5947/#review9178
-----------------------------------------------------------
src/master/dominant_share_allocator.cpp
<https://reviews.apache.org/r/5947/#comment19657>
what does used signify here? I dont think I follow the logic.
src/master/dominant_share_allocator.cpp
<https://reviews.apache.org/r/5947/#comment19658>
can u move this up, since its being used for both if and else. makes it clear that updating frameworks is going to happen irrespective of if..else.
- Vinod Kone
On July 14, 2012, 1:43 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5947/
> -----------------------------------------------------------
>
> (Updated July 14, 2012, 1:43 a.m.)
>
>
> Review request for mesos, Thomas Marshall and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator.hpp 38736cb
> src/master/dominant_share_allocator.hpp 6587f33
> src/master/dominant_share_allocator.cpp 1ea29c7
> src/master/master.hpp 6cb4810
> src/master/master.cpp d6d2905
> src/tests/allocator_tests.cpp 610826b
> src/tests/resource_offers_tests.cpp d06cae2
> src/tests/utils.hpp 780ac2a
>
> Diff: https://reviews.apache.org/r/5947/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>