You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/22 22:52:29 UTC
[GitHub] [incubator-superset] serenajiang opened a new pull request #8996:
[druid] make cluster_name editable
serenajiang opened a new pull request #8996: [druid] make cluster_name editable
URL: https://github.com/apache/incubator-superset/pull/8996
### CATEGORY
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
After #8576, `DruidCluster.cluster_name` is safe to edit because it is no longer a foreign key (it was previously made read-only in #7073).
Adding this mainly because it'd be nice to be able to edit `cluster_name`s without manually touching the database.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TEST PLAN
Confirmed on dev box.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [X] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@john-bodley
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley merged pull request #8996: [druid]
make cluster_name editable
Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #8996: [druid] make cluster_name editable
URL: https://github.com/apache/incubator-superset/pull/8996
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org