You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by vo...@apache.org on 2020/04/26 09:24:35 UTC

[fineract] 01/01: add Policy re. unstable tests to README

This is an automated email from the ASF dual-hosted git repository.

vorburger pushed a commit to branch vorburger-README-flaky-tests
in repository https://gitbox.apache.org/repos/asf/fineract.git

commit c35ab8892879faac4e4714a5d4d1f152b86d3bca
Author: Michael Vorburger ⛑️ <mi...@vorburger.ch>
AuthorDate: Sun Apr 26 11:24:25 2020 +0200

    add Policy re. unstable tests to README
---
 README.md | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 272330a..02c0358 100644
--- a/README.md
+++ b/README.md
@@ -239,15 +239,26 @@ Governance and Policies
 [Becoming a Committer](https://cwiki.apache.org/confluence/display/FINERACT/Becoming+a+Committer)
 documents the process through which you can become a committer in this project.
 
+
+Pull Requests
+-------------
+
+If your PR is failing to pass our CI build due to a test failure which you suspect is a "flaky" test, and not due to a change in your PR, then please do not simply wait for an active maintainer to come and help you, but instead be a proactive contributor to the project, like this: Search for the name of the failed test on https://issues.apache.org/jira/, e.g. for `AccountingScenarioIntegrationTest` you would find [FINERACT-899](https://issues.apache.org/jira/browse/FINERACT-899).  If you [...]
+
 [Pull Request Size Limit](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit)
 documents that we cannot accept huge "code dump" Pull Requests, with some related suggestions.
 
-[How to Release Apache Fineract](https://cwiki.apache.org/confluence/x/DRwIB) documents the process how we make the source code that is available here in this git repository into a binary release ZIP available on http://fineract.apache.org.
-
 Guideline for new Feature commits involving Refactoring: If you are submitting PR for a new Feature, 
 and it involves refactoring, try to differentiate "new Feature code" with "Refactored" by placing
 them in different commits. This helps review to review your code faster.
 
+
+Releasing
+---------
+
+[How to Release Apache Fineract](https://cwiki.apache.org/confluence/x/DRwIB) documents the process how we make the source code that is available here in this Git repository into a binary release ZIP available on http://fineract.apache.org.
+
+
 More Information
 ============
 More details of the project can be found at <https://cwiki.apache.org/confluence/display/FINERACT>.