You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/10/11 15:08:49 UTC

[GitHub] ashb commented on a change in pull request #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links.

ashb commented on a change in pull request #4036: [AIRFLOW-2744] Allow RBAC to accept plugins for views and links.
URL: https://github.com/apache/incubator-airflow/pull/4036#discussion_r224486669
 
 

 ##########
 File path: airflow/plugins_manager.py
 ##########
 @@ -49,6 +49,8 @@ class AirflowPlugin(object):
     admin_views = []
     flask_blueprints = []
     menu_links = []
+    role_based_views = []
+    role_based_menu_items = []
 
 Review comment:
   Lets call these `appbuilder_views` etc. The "role" is just the reason we switched to FAB.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services